Unify Sum and StandardSum aggregates - #9105
Closed
mhk197 wants to merge 15 commits into
Closed
Conversation
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
…s and dead code Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
…s vortex.sum Signed-off-by: Matt Katz <mhkatz97@gmail.com>
…ndardSum, used only by list_sum Signed-off-by: Matt Katz <mhkatz97@gmail.com>
…ns a lazy masked array Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
…accumulate Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
…op arithmetic duplicated by shared-kernel tests Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StandardSumwith a single option-drivenSumaggregatevortex.sumID and select the partial shape from optionsThis is a self-contained replacement for #8705 and targets
developdirectly.Tests
cargo nextest run -p vortex-array(3187 passed, 1 skipped)cargo nextest run -p vortex-sparse(107 passed)cargo nextest run -p vortex-layout zoned(40 passed)cargo test --doc -p vortex-array(72 passed, 10 ignored)cargo clippy --all-targets --all-featurescargo +nightly fmt --allgit diff --checkWorkspace-wide Clippy and the
vortex-duckdbcheck are blocked before Rust compilation because the external DuckDB v1.5.3 prebuilt archive returns HTTP 404.