Skip to content

fix[frontend](integration):generated secret state lifetime update - #2408

Merged
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_integration_secrets
Jul 29, 2026
Merged

fix[frontend](integration):generated secret state lifetime update#2408
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_integration_secrets

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

🛑 AI review — High/critical findings

One or more high/critical issues were found. Please review and fix before merging if they're real.

⚠️ architecture (gemini-3-flash-lite) — minor findings

Summary: Incorrect useEffect dependency array in RemoteEnablePanel component leading to stale state or missing reset behavior.

  • medium frontend/src/features/integrations/components/setup/collector/RemoteEnablePanel.tsx:190 — Removed collectorId from the dependency array of useEffect which resets generatedSecret. This may cause the secret not to clear when the collector changes; restore collectorId to the dependency array.

🛑 bugs (gemini-3-flash-lite) — high/critical — please review

Summary: Incorrect useEffect dependency array change causes generated secret to persist across collector IDs

  • high frontend/src/features/integrations/components/setup/collector/RemoteEnablePanel.tsx:190 — Changing the useEffect dependency array from [collectorId] to [] breaks state reset when collectorId changes. The generated secret will now persist when switching between collectors, potentially showing the wrong secret for a new collector.

security (gemini-3-flash-lite) — clean

Summary: The PR diff only modifies React hook dependency arrays in a component and introduces no vulnerabilities or information disclosures.

No findings.

🟢 go-deps — up to date

No pending Go dependency updates.

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor Author

changing collectors reset this component, so no reactivity is needed

@AlexSanchez-bit
AlexSanchez-bit merged commit ce18526 into release/v12.0.0 Jul 29, 2026
1 check passed
@AlexSanchez-bit
AlexSanchez-bit deleted the backlog/v12_integration_secrets branch July 29, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant