Render the built-in filter clause from a template table. - #4
Merged
Conversation
Each operator carried its own match arm, so the cyclomatic complexity of the function grew with every operator and had already reached the ceiling the linter enforces. The arms only ever differed by the SQL template, so a lookup keyed by the operator token expresses the same mapping and keeps the complexity flat.
The operator renders as an anchored LIKE so a B-tree index on the column stays usable, and every wildcard inside the value is escaped before binding, so a search for a literal percent sign cannot expand into a scan. There is no unanchored counterpart by design, since it cannot use the index and degrades the listing into a table scan as the data grows. The escape character is an exclamation mark rather than the customary backslash. A backslash needs one spelling under the default MySQL mode and another under NO_BACKSLASH_ESCAPES, where the usual form fails with Incorrect arguments to ESCAPE, so no single literal is valid in both. Case and accent insensitivity come from the column collation instead, so the rendered predicate carries no vendor-specific COLLATE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What this pull request does.
Related issue
Closes #...
Checklist
composer reviewpasses.composer testspasses.