Distinguish a client error from a server failure. - #3
Merged
Conversation
An unmapped exception was always answered with a generic 500, which told a caller that mistyped a URL that the server had failed, and kept a client that retries on 5xx retrying a request that can never succeed. The routing exceptions a PSR-15 stack raises already carry the status, so the fallback now adopts it when it is a client error and keeps the generic 500 for everything else. The log level follows the same distinction and derives from the status actually returned, so a validation failure a consumer maps to 422 stops inflating every error-rate signal built on top of the logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What this pull request does.
Related issue
Closes #...
Checklist
composer reviewpasses.composer testspasses.