Fix stale docs and align conventions across the AI samples - #334
Open
brianstrauch wants to merge 6 commits into
Open
Fix stale docs and align conventions across the AI samples#334brianstrauch wants to merge 6 commits into
brianstrauch wants to merge 6 commits into
Conversation
- strands_plugin: drop the note about the `strands` extra not being released yet, along with its install-from-branch fallback - strands_plugin/tools: `activity_as_tool` lives in `temporalio.contrib.strands.workflow`, not `workflow` - strands_plugin/continue_as_new: the workflow waits on `is_continue_as_new_suggested()` in a `wait_condition`, not per turn - langgraph_plugin/graph_api/streaming: point `WorkflowStream` at the SDK docs instead of the docs.temporal.io root Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The rule at the top of the file duplicated the one in the AI SDK section further down, which also covers /tests/langgraph_plugin/. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Three READMEs linked docs.temporal.io/cli#start-dev-server, whose anchor does
not match a heading on that page ("Start a development server"), so it landed
at the top. /cli/server#start-dev matches the reference page's `start-dev`
heading exactly, and is what the Google ADK samples already used.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Both anchored forms of the dev server link are replaced with the unanchored docs.temporal.io/cli, and each prerequisite now shows the command it is asking for, following external_storage/README.md. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Matches the other READMEs, which link the CLI docs page without an anchor. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
- Google ADK scripts read TEMPORAL_ADDRESS with a localhost:7233 default, as the Strands and LangGraph samples already do. - Google ADK docs invoke scripts by path (`uv run <dir>/run_worker.py`) rather than `uv run python -m <module>`, matching the other suites. - Strands samples use `str | None` instead of `Optional[str]`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A docs and consistency pass over the Strands, LangGraph, and Google ADK samples. No sample behavior changes.
Stale references
strands_plugin/README.md: drop the note saying thestrandsextra "is shipping in an upcoming release" along with itsuv pip install -e ../sdk-pythonfallback —pyproject.tomlalready pinstemporalio[strands-agents,pydantic]>=1.30.0. (It also named the extrastrands; the real name isstrands-agents.)strands_plugin/tools/README.md:activity_as_toolis imported fromtemporalio.contrib.strands.workflow, notworkflow.strands_plugin/continue_as_new/README.md: the workflow waits onis_continue_as_new_suggested()in await_condition, not after each turn.langgraph_plugin/graph_api/streaming/README.md:WorkflowStreamlinked to the docs.temporal.io root; point it at the SDKcontrib/workflow_streamspath.Dev server links
Every dev server reference now links the unanchored https://docs.temporal.io/cli and shows the command, following
external_storage/README.md. The repo previously had two forms:/cli#start-dev-server, whose anchor does not match any heading on that page, and/cli/server#start-dev.Conventions
TEMPORAL_ADDRESS— all 12 Google ADK scripts now read it with alocalhost:7233default, as the Strands and LangGraph samples already did.uv run google_adk_agents/basic/run_worker.py) instead ofuv run python -m google_adk_agents.basic.run_worker, matching the other suites.Optional[str]→str | Nonein the two Strands samples still using the old form; the rest of the suite already used it.Other
.github/CODEOWNERS: the/langgraph_plugin/rule at the top of the file duplicated the one in the AI SDK section, which also covers/tests/langgraph_plugin/.Verification
ruff check(incl. import sort) andruff format --checkclean;mypy --check-untyped-defs --namespace-packagesclean across 73 files.pytest tests/google_adk_agents tests/strands_plugin— 15 passed.TEMPORAL_ADDRESS=127.0.0.1:1 python google_adk_agents/basic/run_worker.py): imports resolve, and it reaches a connection-refused as expected with no server running.🤖 Generated with Claude Code