Skip to content

docs: fix C API examples in blas/ext/base/zwxmy - #13802

Merged
kgryte merged 1 commit into
developfrom
philipp/fix-commit-review-2026-07-31
Jul 31, 2026
Merged

docs: fix C API examples in blas/ext/base/zwxmy#13802
kgryte merged 1 commit into
developfrom
philipp/fix-commit-review-2026-07-31

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-07-30 14:56 PT (22f4f46) and 2026-07-31 04:19 PT (a669750).

This pull request:

  • blas/ext/base/zwxmy: Fixed blas/ext/base/zwxmy README examples (451c6c8): the C snippets for stdlib_strided_zwxmy/stdlib_strided_zwxmy_ndarray declared x/w as float arrays cast to stdlib_complex128_t *, an 8-byte-per-element vs. 16-byte-per-element mismatch causing OOB reads and float-as-double reinterpretation for N=4. Changed both declarations to double with matching literals in lib/node_modules/@stdlib/blas/ext/base/zwxmy/README.md, consistent with the zxmy/zany sibling docs.
  • blas/ext/base/zwxmy: Fixes the C "Examples" section in blas/ext/base/zwxmy/README.md (introduced in 451c6c8) to match examples/c/example.c: drops the erroneous f suffixes from all twelve stdlib_complex128 literals and switches the printf format specifier from %f to %lf.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. All 27 commits merged to develop in the last 24 hours were reviewed for typos, bugs, and stdlib style-guide compliance: two independent style-compliance passes (checked against docs/style-guides and established sibling packages such as gtriu, zxmy, dindex-of), plus two independent bug-scan passes over the union diff (strided-loop index arithmetic, native addon marshalling, C benchmark refactors, README/repl example outputs, ULP tolerance translations in the migrated math/base/special tests). Only issues that were objective, independently re-verifiable from the diff, and fixable without touching code outside the diff window were retained. Deliberately excluded: subjective suggestions, style preferences not mandated by the style guides, and missing entries in the auto-generated blas/ext/base aggregate README/TypeScript declarations (the regeneration commits simply predate the namespace wiring; the next regeneration run will pick them up).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was produced by a scheduled automated review: Claude Code reviewed the last 24 hours of commits merged to develop and authored the fixes. A human maintainer will audit before promoting this draft.


Generated by Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UN61jV6C144EpKHXKNXsG4
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jul 31, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/zwxmy $\\color{green}458/458$
$\\color{green}+100.00\\%$
$\\color{green}27/27$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}458/458$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Planeshifter marked this pull request as ready for review July 31, 2026 14:59
@Planeshifter
Planeshifter requested review from a team and anandkaranubc July 31, 2026 14:59
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. labels Jul 31, 2026
@anandkaranubc anandkaranubc added the Documentation Improvements, additions, or changes to documentation. label Jul 31, 2026
kgryte
kgryte approved these changes Jul 31, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 31, 2026
@kgryte
kgryte merged commit 382065d into develop Jul 31, 2026
88 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-07-31 branch July 31, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Documentation Improvements, additions, or changes to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants