test: migrate math/base/special/asec to ULP-based testing - #13789
test: migrate math/base/special/asec to ULP-based testing#13789Planeshifter wants to merge 1 commit into
math/base/special/asec to ULP-based testing#13789Conversation
Resolves a part of #11352
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
left a comment
There was a problem hiding this comment.
The OP needs to be updated as described in the comments.
Description
This PR migrates the test suite for
math/base/special/asecfrom relative-tolerance testing to ULP difference testing, per the tracking issue.EPS/abs-based tolerance checks with@stdlib/number/float64/base/assert/is-almost-same-value.isAlmostSameValue( y, expected[ i ], 1 ).test.jsandtest.native.js) was 1 ULP, so1is used as the tightest bound.test/test.jsandtest/test.native.jswere updated identically (the native test just skips when no native addon is built, unchanged from before).Only the package's own test files were changed; no other files were modified.
Resolves a part of #11352
Generated by Claude Code