Skip to content

feat(ci): add custom linters - #1642

Open
rubenhoenle wants to merge 1 commit into
mainfrom
acl-linter
Open

feat(ci): add custom linters#1642
rubenhoenle wants to merge 1 commit into
mainfrom
acl-linter

Conversation

@rubenhoenle

Copy link
Copy Markdown
Member

Description

relates to STACKITTPR-619, #1362

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

relates to STACKITTPR-619, #1362
@rubenhoenle
rubenhoenle requested a review from a team as a code owner July 31, 2026 12:37
@github-actions

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/cdn/distribution 54.73% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/recordset 17.39% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/zone 18.56% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dremio/instance 22.65% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dremio/user 7.66% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/edgecloud/kubeconfig 4.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/edgecloud/token 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/image 36.81% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/network 47.28% (-0.19%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/networkarearegion 30.67% (-0.20%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaasalpha/vpcnetworkrange 11.63% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaasalpha/vpcregion 5.88% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1/generic 11.45% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/loadbalancer/loadbalancer 52.25% (-0.08%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/objectstorage/compliance-lock 4.61% (-0.03%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/objectstorage/credential 21.78% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/objectstorage/credentialsgroup 17.54% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/postgresflex/database 5.98% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager/instance 22.63% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/serviceaccount/federated_identity_provider 23.98% (-0.67%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster 48.37% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/kubeconfig 25.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/tools/internal/lintutils 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/tools/linters/tfacl 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/tools/linters/tfctxinit 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/tools/linters/tflogresponse 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/tools/linters/tfwriteid 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/cdn/distribution/resource.go 50.26% (ø) 579 291 288
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/recordset/resource.go 21.05% (ø) 228 48 180
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/zone/resource.go 23.79% (ø) 227 54 173
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dremio/instance/resource.go 29.18% (ø) 281 82 199
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dremio/user/resource.go 9.52% (ø) 168 16 152
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/edgecloud/kubeconfig/resource.go 4.00% (ø) 150 6 144
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/edgecloud/token/resource.go 0.00% (ø) 143 0 143
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/image/resource.go 31.36% (ø) 287 90 197
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/network/resource.go 43.13% (-0.23%) 371 (+2) 160 211 (+2) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/networkarearegion/datasource.go 0.00% (ø) 38 (+2) 0 38 (+2)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/networkarearegion/resource.go 34.91% (ø) 275 96 179
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaasalpha/vpcnetworkrange/resource.go 13.61% (ø) 294 40 254
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaasalpha/vpcregion/resource.go 7.29% (ø) 192 14 178
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1/generic/datasource.go 18.18% (ø) 44 8 36
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1/generic/resource.go 9.02% (ø) 122 11 111
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/loadbalancer/loadbalancer/resource.go 55.94% (-0.10%) 581 (+1) 325 256 (+1) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/objectstorage/compliance-lock/resource.go 6.14% (-0.05%) 114 (+1) 7 107 (+1) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/objectstorage/credential/resource.go 21.30% (ø) 230 49 181
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/objectstorage/credentialsgroup/datasource.go 0.00% (ø) 40 0 40
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/objectstorage/credentialsgroup/resource.go 21.64% (ø) 171 37 134
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/postgresflex/database/datasource.go 0.00% (ø) 46 0 46
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/postgresflex/database/resource.go 7.32% (ø) 205 15 190
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager/instance/datasource.go 0.00% (ø) 41 0 41
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager/instance/resource.go 26.61% (ø) 233 62 171
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/serviceaccount/federated_identity_provider/datasource.go 0.00% (ø) 34 (+1) 0 34 (+1)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/serviceaccount/federated_identity_provider/resource.go 31.18% (-0.94%) 170 (+5) 53 117 (+5) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster/resource.go 50.44% (ø) 912 460 452
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/kubeconfig/resource.go 25.00% (ø) 180 45 135
github.com/stackitcloud/terraform-provider-stackit/tools/internal/lintutils/lintutil.go 0.00% (ø) 0 0 0
github.com/stackitcloud/terraform-provider-stackit/tools/linters/tfacl/tfacl.go 0.00% (ø) 0 0 0
github.com/stackitcloud/terraform-provider-stackit/tools/linters/tfctxinit/tfctxinit.go 0.00% (ø) 0 0 0
github.com/stackitcloud/terraform-provider-stackit/tools/linters/tflogresponse/tflogresponse.go 0.00% (ø) 0 0 0
github.com/stackitcloud/terraform-provider-stackit/tools/linters/tfwriteid/tfwriteid.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager/instance/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager/secretsmanager_acc_test.go


// IsTerraformLifecycleMethod is used to check whether an AST function declaration is a Terraform resource
// lifecycle implementation (CRUD)
func IsTerraformLifecycleMethodCreateOnlyTODO(funcDecl *ast.FuncDecl) bool {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open TODO?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants