fix(ske): fix planModifiers for update - #1636
Open
Manuelvaas wants to merge 1 commit into
Open
Conversation
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
marceljk
reviewed
Jul 31, 2026
Comment on lines
+97
to
+98
| // This function is the pathExpression compatible version of StringUnchanged and should replace StringUnchanged in the future | ||
| func StringUnchangedExpressionFunction(pathExpressions ...path.Expression) UseStateForUnknownIfFunc { // nolint:gocritic // function signature required by Terraform |
Contributor
There was a problem hiding this comment.
I think it would be nice to extend the description a bit, to avoid misuse. It's possible here to provide multiple path.Expressions and someone could assume, that only if all path.Expressions remain unchanged, it will use UseStateForUnknown. But if I got it correctly, it sets UseStateForUnknown as soon one of the path.Expression remained the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITTPR-775
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)