feat(git): add ability for users to update git resources - #1634
Draft
tomkillen wants to merge 2 commits into
Draft
feat(git): add ability for users to update git resources#1634tomkillen wants to merge 2 commits into
tomkillen wants to merge 2 commits into
Conversation
rubenhoenle
reviewed
Jul 30, 2026
| subcategory: "" | ||
| description: |- | ||
| Git Instance resource schema. | ||
| ~> This resource is in beta and may be subject to breaking changes in the future. Use with caution. See our guide https://registry.terraform.io/providers/stackitcloud/stackit/latest/docs/guides/opting_into_beta_resources for how to opt-in to use beta resources. This resource currently does not support updates. Changing the ACLs, flavor, or name will trigger resource recreation. Update functionality will be added soon. In the meantime, please proceed with caution. To update these attributes, please open a support ticket. |
Member
There was a problem hiding this comment.
Short note without any deep review: We're still consuming the v1beta STACKIT git API here, so this must stay marked as beta
rubenhoenle
reviewed
Jul 30, 2026
| } | ||
|
|
||
| // toPatchPayload creates the payload to update a git instance | ||
| func toPatchPayload(ctx context.Context, model *Model) (git.PatchInstancePayload, diag.Diagnostics) { |
Member
There was a problem hiding this comment.
Suggested change
| func toPatchPayload(ctx context.Context, model *Model) (git.PatchInstancePayload, diag.Diagnostics) { | |
| func toUpdatePayload(ctx context.Context, model *Model) (git.PatchInstancePayload, diag.Diagnostics) { |
Your function is named toPatchPayload, the test is named TestToUpdatePayload. Keep it consistent.
If you need help making a decision, toUpdatePayload is the better name IMO. 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves #1633
Note: depends on adding the update waiter to stackit-sdk-go (see PR for stackit-sdk-go here stackitcloud/stackit-sdk-go#9328)
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)