Chore/stackittpr 739 change semver library - #1627
Open
cgoetz-inovex wants to merge 3 commits into
Open
Conversation
- original implementation worked with KubernetesVersion and MachineImageVersion structs - from both types the version and state fields were used during version selection - introduced interface VersionWithState to cover both cases - introduce helper funcs for working with this interface: toVersionWithState, sortVersions, isDeprecated, isPreview, isSupported - consolidated getLatestSupportedMachineVersion and getLatestSupportedKubernetesVersion into getLatestSupportedVersion - test cases for these two functions were the same with the only difference being the type - consolidated TestGetLatestSupportedKubernetesVersion and TestGetLatestSupportedMachineVersion into TestGetLatestSupportedVersion - convert to VersionWithState early in call tree - extracted common parts into latestMatchingVersion - replace regex check for full version and selectFullVersion selectMatchingVersion with constraint and single selectVersion - move calculation of available out of selectVersion and into error branch, when no version could be found
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've used the mastermind semver library, since we already had it in our transitive deps
structs
selection
sortVersions, isDeprecated, isPreview, isSupported
getLatestSupportedKubernetesVersion into getLatestSupportedVersion
difference being the type
TestGetLatestSupportedMachineVersion into TestGetLatestSupportedVersion
selectMatchingVersion with constraint and single selectVersion
branch, when no version could be found
relates to #1234
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)