fix: make sure trailing dot is present for targets of dns records (#73) - #74
Open
stijzermans wants to merge 1 commit into
Open
fix: make sure trailing dot is present for targets of dns records (#73)#74stijzermans wants to merge 1 commit into
stijzermans wants to merge 1 commit into
Conversation
stijzermans
force-pushed
the
fix/trailing-dots-in-targets
branch
from
July 2, 2026 16:49
06a6b78 to
d96e515
Compare
ondbeh
approved these changes
Jul 29, 2026
Contributor
|
Hi @stijzermans, first of all - thank you for the contribution and sorry for getting back to you with a delay. Can you please just fix the linting error from the test? I think in this case you can just add a lint ignore annotation. Since this change introduces a breaking change, we will take it as an opportunity to release version 1.0.0 of our webhook. For that, we have a few feature in mind that we would like to add. Therefore, in the meantime, I will create a pre-release with your contribution. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a fix for issue #73, based on the implementation of:
https://github.com/kubernetes-sigs/external-dns/blob/066a11e2158f87689a01f0ff39493037da958171/provider/google/google.go#L427-L467