Skip to content

Add more details for load balancers in error state - #1410

Merged
ske-prow[bot] merged 2 commits into
mainfrom
moreDetailedLBErrors
Jul 30, 2026
Merged

Add more details for load balancers in error state#1410
ske-prow[bot] merged 2 commits into
mainfrom
moreDetailedLBErrors

Conversation

@dergeberl

@dergeberl dergeberl commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

Returns more detailed errors for LBs when available in SDK.

Which issue(s) this PR fixes:

@ske-prow ske-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2026
@dergeberl

dergeberl commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

/kind enhancement

@ske-prow ske-prow Bot added kind/enhancement Enhancement, improvement, extension and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 24, 2026
@dergeberl
dergeberl force-pushed the moreDetailedLBErrors branch from 0d80684 to f326bbc Compare July 24, 2026 11:57
@dergeberl

dergeberl commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

Tested with an invalid external IP.

Before:
image
After:
image

@dergeberl
dergeberl force-pushed the moreDetailedLBErrors branch from f326bbc to e3d88c0 Compare July 24, 2026 13:21
@dergeberl dergeberl changed the title WIP: Add more details for load balancers in error state Add more details for load balancers in error state Jul 24, 2026
@ske-prow ske-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2026
@dergeberl

dergeberl commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

/cc @stackitcloud/ske-infrastructure

@ske-prow
ske-prow Bot requested a review from a team July 24, 2026 13:22
@dergeberl dergeberl mentioned this pull request Jul 27, 2026
Open
fischerman
fischerman reviewed Jul 28, 2026
View reviewed changes
Comment thread pkg/ccm/loadbalancer_test.go Outdated
fischerman
fischerman reviewed Jul 28, 2026
View reviewed changes
Comment thread pkg/ccm/loadbalancer_test.go Outdated
@dergeberl
dergeberl force-pushed the moreDetailedLBErrors branch from ed3880d to 6c1688e Compare July 29, 2026 12:29
@ftl

ftl commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2026
@ske-prow

ske-prow Bot commented Jul 30, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: fce6a6c505417ba7cce814c8622cbc1da5627f45

@dergeberl

dergeberl commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

/approve

@ske-prow

ske-prow Bot commented Jul 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dergeberl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2026
@dergeberl

dergeberl commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

@stackit-ske

stackit-ske commented Jul 30, 2026

Copy link
Copy Markdown

@dergeberl: once the present PR merges, I will cherry-pick it on top of release-v1.34, release-v1.35, release-v1.36 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ske-prow
ske-prow Bot merged commit dd1549c into main Jul 30, 2026
3 checks passed
@ske-prow
ske-prow Bot deleted the moreDetailedLBErrors branch July 30, 2026 10:13
@stackit-ske

stackit-ske commented Jul 30, 2026

Copy link
Copy Markdown

@dergeberl: new pull request created: #1441

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jul 30, 2026
Merged
@stackit-ske

stackit-ske commented Jul 30, 2026

Copy link
Copy Markdown

@dergeberl: new pull request created: #1442

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jul 30, 2026
Merged
@stackit-ske

stackit-ske commented Jul 30, 2026

Copy link
Copy Markdown

@dergeberl: new pull request created: #1443

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jul 30, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fischerman fischerman fischerman left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dergeberl @ftl @stackit-ske @fischerman