Add Deployment to delete_orphaned_resources - #1256
Merged
Merged
Conversation
Member
|
This is actually a bugfix of #992, good catch! |
Maleware
marked this pull request as ready for review
July 31, 2026 14:30
Member
Author
|
That's good to know! Thanks for adding that. Then we might be good to merge it, I wanted to think about wether this has impact somewhere else, but doesn't seem like. |
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing OPA being a deployment, we should take care of orphaned deployment clean-ups as it will be possible to switch from
DeploymenttoDaemonSetFixup of #992