Skip to content

improvement(workspace): remove tip - #6141

Merged
icecrasher321 merged 1 commit into
stagingfrom
staging-v20
Jul 31, 2026
Merged

improvement(workspace): remove tip #6141
icecrasher321 merged 1 commit into
stagingfrom
staging-v20

Conversation

@icecrasher321

Copy link
Copy Markdown
Collaborator

Summary

remove + simplify modal header text for create workspace

Type of Change

  • Other: UX Improvement

Testing

N/A

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 31, 2026 11:33pm

Request Review

@cursor

cursor Bot commented Jul 31, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
UI-only copy and prop cleanup in the create-workspace flow; creation behavior and policy gating elsewhere are unchanged.

Overview
Simplifies the Create workspace modal by dropping contextual title/description copy and the target prop that drove personal vs organization messaging.

The modal now always shows a fixed Create workspace header (no explanatory paragraph about personal account or org policy). workspace-header no longer derives createWorkspaceTarget from workspaceCreationPolicy or useActiveOrganization, and the dedicated getCreateWorkspaceCopy tests are removed with that helper.

Reviewed by Cursor Bugbot for commit b5bec55. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Simplifies the create-workspace modal by:

  • Replacing ownership-specific titles with a generic “Create workspace” heading.
  • Removing the ownership and workspace-policy description.
  • Removing the now-unused organization lookup, target prop, copy helper, and helper tests.

Confidence Score: 4/5

The PR is safe to merge, with a non-blocking UX concern that the modal no longer identifies the server-selected workspace ownership scope.

Workspace creation behavior remains unchanged, but users creating under an organization policy lose the modal copy that explained where the workspace would belong before submission.

Files Needing Attention: apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/components/create-workspace-modal/create-workspace-modal.tsx

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/components/create-workspace-modal/create-workspace-modal.tsx Simplifies the modal heading and removes the only pre-submit indication of the server-selected workspace ownership scope.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/workspace-header.tsx Removes the organization lookup and target construction that were used exclusively for the deleted modal copy.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/components/create-workspace-modal/create-workspace-modal.test.ts Removes tests for the deleted target-specific copy helper.

Reviews (1): Last reviewed commit: "improvement(workspace): remove tip + sim..." | Re-trigger Greptile

@icecrasher321
icecrasher321 merged commit b77b9ee into staging Jul 31, 2026
27 checks passed
@icecrasher321
icecrasher321 deleted the staging-v20 branch July 31, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant