fix(pi): surface provider errors from agent events - #6133
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Cloud Pi integration tests were updated to simulate this real stream (including zero CLI exit) and assert the run throws with a scrubbed provider message, stops before commit/push/PR (two sandbox commands only). Reviewed by Cursor Bugbot for commit 9eb6d0c. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummarySurface terminal Pi provider errors while preserving retry behavior.
Confidence Score: 5/5The PR appears safe to merge with terminal provider errors now propagated without treating explicit retries as failures. The changed event normalization feeds existing error accumulation and propagation paths, while the retry guard prevents transient failures from prematurely terminating execution.
|
| Filename | Overview |
|---|---|
| apps/sim/executor/handlers/pi/events.ts | Correctly distinguishes retrying provider failures from terminal error or aborted agent completion events. |
| apps/sim/executor/handlers/pi/events.test.ts | Adds focused coverage for terminal failures, aborted runs, retries, and successful agent completion. |
| apps/sim/executor/handlers/pi/cloud-backend.test.ts | Verifies a zero-exit Pi process with a terminal provider error aborts before repository finalization or PR creation. |
Reviews (1): Last reviewed commit: "fix(pi): surface provider errors from ag..." | Re-trigger Greptile
| } | ||
| case 'agent_end': | ||
| case 'agent_end': { | ||
| if (ev.willRetry === true) return { type: 'other' } |
There was a problem hiding this comment.
could you explain what this is doing?
There was a problem hiding this comment.
Well if willRetry is yes, then the block should't fail, it should try again. A 429 error is an example.

Summary
Type of Change
Testing
Checklist