improvement(ui): drop full-content hover tooltips - #6128
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Knowledge & resource UI: Chunk table rows no longer use overflow tooltips for content (including cases where Workflow canvas: Loop/parallel and note block titles switch from native Reviewed by Cursor Bugbot for commit aef1aee. Configure here. |
Greptile SummaryThe PR removes unconditional full-content tooltips and consistently clip-gates remaining overflow tooltips.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported optional note-name typing issue is fixed by supplying an empty-string fallback to OverflowSpan.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/components/resource/components/resource-header/resource-header.tsx | Replaces the unreachable overflow tooltip on the non-shrinking resource title with plain text. |
| apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx | Removes full chunk-content hover tooltips while retaining truncated preview rendering. |
| apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx | Introduces a tags cell whose detailed tooltip appears only when the inline values are clipped. |
| packages/workflow-renderer/src/note/note-block-view.tsx | Replaces the native note-name title with a clip-gated OverflowSpan and safely handles omitted names. |
| packages/workflow-renderer/src/subflow/subflow-node-view.tsx | Replaces the native subflow-name title with a clip-gated OverflowSpan. |
| packages/workflow-renderer/src/workflow-block/sub-block-row-view.tsx | Removes full-value hover tooltips from collapsed workflow sub-block rows. |
Reviews (2): Last reviewed commit: "fix(workflow-renderer): default the opti..." | Re-trigger Greptile
- remove the chunk-content tooltip in the KB chunks table (it forced the full chunk body on every truncated row) - remove the sub-block value tooltip on collapsed workflow blocks (whole prompts/code/JSON on hover) - replace the native `title` on subflow and note blocks with the clip-gated OverflowSpan - clip-gate the KB documents tags cell so it stops firing on fully visible tags - drop the dead tooltip on the resource header root title, which can never truncate
d693723 to
aef1aee
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit aef1aee. Configure here.
Summary
showWhen, which bypassed the clip gate and forced the entire chunk body into a tooltip on every truncated rowtitleattribute on subflow (loop/parallel) and note blocks with the clip-gatedOverflowSpan— those fired the raw browser tooltip unconditionally, even on fully visible names, against the rule documented inoverflow-span.tsxname: valuebreakdown is preserved when the text is actually clipped)whitespace-nowrapinside ashrink-0container, so it could never clip and the tooltip could never fireLeft alone: clip-gated tooltips on names/labels (table cells, filenames, workflow names, breadcrumbs), icon-only connector chips, and the canvas badge tooltips that convey a click affordance.
Type of Change
Testing
Tested manually
Checklist