Pi: Fix Pinecone vector-search output options. The Pinecone block expose... - #6066
Pi: Fix Pinecone vector-search output options.
The Pinecone block expose...#6066BillLeoutsakosvl346 wants to merge 3 commits into
Conversation
The Pinecone block expose...
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview When Reviewed by Cursor Bugbot for commit 128451b. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryMaps Pinecone vector-search checkbox options into query flags and stops hardcoding includeValues/includeMetadata as true.
Confidence Score: 5/5This PR appears safe to merge; the prior string-"false" coercion issue is addressed and no blocking failure remains. parseBoolean only treats true/1 as true, checkbox-selected IDs drive the query flags when options are present, and tests cover the option matrix without requiring live Pinecone credentials.
|
| Filename | Overview |
|---|---|
| apps/sim/tools/pinecone/search_vector.ts | Uses checkbox option IDs for includeValues/includeMetadata and parseBoolean so string "false" no longer becomes true. |
| apps/sim/tools/pinecone/search_vector.test.ts | Covers neither, values-only, metadata-only, and both option mappings on the request body builder. |
| apps/sim/blocks/blocks/pinecone.ts | Exposes options on block inputs alongside existing includeValues/includeMetadata fields. |
| apps/sim/tools/pinecone/types.ts | Adds optional options string[] |
Reviews (3): Last reviewed commit: "Pi Babysit: address PR #6066 feedback" | Re-trigger Greptile
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1773d7c. Configure here.

Task
Fix Pinecone vector-search output options.
The Pinecone block exposes Include Values and Include Metadata checkboxes for the search_vector operation, but apps/sim/tools/pinecone/search_vector.ts always sends both fields as true.
Trace how the options checkbox list is serialized and map its selected IDs to includeValues and includeMetadata in the tool parameters. Use those parameters in the Pinecone query body instead of hardcoded values.
Add focused tests covering neither option, each option individually, and both options. Do not require a live Pinecone account or API key for testing. Run the relevant tests, Biome, and TypeScript checks.
Summary
Implemented Pinecone vector-search option handling.
Changes:
apps/sim/tools/pinecone/search_vector.tsincludeValuesandincludeMetadataparameters.falsewhen unchecked.apps/sim/tools/pinecone/search_vector.test.tsValidation could not be run because
bunxis unavailable in the sandbox (bunx: command not found).