fix(desktop): release script - #6060
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryFixes desktop share packaging and production origin migration.
Confidence Score: 3/5Not fully safe to merge until setOrigin also applies the apex origin rewrite, or users who enter https://sim.ai stay broken until restart. Load-time migration and share packaging look correct and well tested, but setOrigin can still persist the apex production origin and immediately drive the wrong cookie partition and social-login classification for the rest of that session. Files Needing Attention: apps/desktop/src/main/config.ts (setOrigin)
|
| Filename | Overview |
|---|---|
| apps/desktop/scripts/package-share.ts | Sequential multi-channel share packager with correct origin baking, productName/appId overrides, and artifact naming. |
| apps/desktop/scripts/channels.ts | Build-time channel identity table mirrored to runtime channelForOrigin/APP_NAME_FOR_CHANNEL. |
| apps/desktop/src/main/config.ts | Apex origin rewrite on load is sound; setOrigin still skips canonicalOrigin so apex can be reintroduced until restart. |
| apps/desktop/src/main/index.ts | Dock icon set only when unpackaged on Darwin to avoid soft Retina packaged icons. |
| apps/desktop/package.json | package:share now runs the new TypeScript packager script. |
Comments Outside Diff (1)
-
apps/desktop/src/main/config.ts, line 329-339 (link)When
setOriginis called withhttps://sim.ai, it stores the validated apex origin withoutcanonicalOrigin, so until restartgetOriginstays on the apex,partitionForOriginleavespersist:sim, and social login is classified as an integration connect instead of the system-browser handoff.
Reviews (1): Last reviewed commit: "fix" | Re-trigger Greptile
…e select descriptions from mothership #373)
|
Summary
Desktop release fixes, plus the sim side of the mothership
validation_errorincident fix: VFS grep now truncates oversized matched/context lines at 2K chars (a minified single-line file — workflow JSON, persisted tool results — otherwise returns whole as one "match"). Also syncs the generated mothership contract mirrors (user_tableselect-column descriptions from mothership #373, which were never regenerated on the sim side).Type of Change
Testing
operations.test.ts21/21 passbun run mship:generate→ clean)Checklist
Companion PR
Companion: https://github.com/simstudioai/mothership/pull/379