Skip to content

improvement(search): prioritize workspaces in command palette - #6054

Open
BillLeoutsakosvl346 wants to merge 1 commit into
stagingfrom
improvement/command-k-workspaces-first
Open

improvement(search): prioritize workspaces in command palette#6054
BillLeoutsakosvl346 wants to merge 1 commit into
stagingfrom
improvement/command-k-workspaces-first

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • move Workspaces directly below Actions in Command-K
  • keep the canonical section order aligned with the rendered palette
  • add rendered regression coverage for default, searched, and canvas-restricted palettes

Why

Command-K fuzzy-ranks items within each group, but the groups themselves use a fixed order. Chats rendered before Workspaces, so a user with many similarly named chats could have to scroll through chat results before reaching a workspace match.

Before / after

  • Before: Actions → … → Chats → Workflows → … → Workspaces
  • After: Actions → Workspaces → … → Chats → Workflows → …

Workspace fuzzy ranking and existing recent-workspace ordering are unchanged.

Validation

  • focused search-modal, search utility, and search store suites — 32 tests passed
  • cd apps/sim && bun run type-check — passed
  • tracked app files: Biome format and lint checks passed
  • focused changed files: Biome format and lint checks passed
  • git diff --check — passed

The app-wide local Biome command also scanned pre-existing untracked Playwright run artifacts, which are intentionally excluded from this PR and left untouched.

@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 29, 2026 5:51pm

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cursor @greptile-apps Please review this Command-K ordering improvement and its regression coverage. Flag any correctness, keyboard-navigation, search-ranking, or scoped-palette issues before merge.

@cursor

cursor Bot commented Jul 29, 2026

Copy link
Copy Markdown

You need to increase your spend limit or enable usage-based billing to run background agents. Go to Cursor

@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Reorders Command-K so Workspaces sit directly under Actions, with matching canonical section order and regression tests.

  • Moves the Workspaces group render after Actions in search-modal.tsx
  • Moves workspaces earlier in SEARCH_SECTIONS in types.ts
  • Adds jsdom coverage for default, searched, and canvas-restricted palette section order

Confidence Score: 5/5

The PR appears safe to merge; no blocking failures remain from prior or current review scope.

No blocking failure remains; the change only reorders an existing palette section and adds tests without altering visibility or selection behavior.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx Renders Workspaces immediately after Actions; visibility and handlers unchanged.
apps/sim/stores/modals/search/types.ts Aligns SEARCH_SECTIONS so workspaces follows actions in the canonical order.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.test.tsx Adds section-order regression tests for default, search, and canvas-restricted palettes.

Reviews (2): Last reviewed commit: "improvement(search): prioritize workspac..." | Re-trigger Greptile

@BillLeoutsakosvl346
BillLeoutsakosvl346 marked this pull request as ready for review July 29, 2026 18:00
@cursor

cursor Bot commented Jul 29, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
UI-only search palette ordering with aligned constants and new component tests; no auth, data, or API changes.

Overview
Command-K now lists Workspaces immediately after Actions (before Chats and the rest), so workspace matches appear higher when groups are fixed-order and fuzzy search runs per section.

SEARCH_SECTIONS and the SearchModal render order were updated together so the canonical section list matches what the palette shows. Workspace ranking and canvas-restricted palettes (subset sections) are unchanged—Workspaces still only appear when that section is allowed.

Adds Vitest regression tests for default heading order, searched order (workspace before chat for the same query), and workflow canvas palettes that omit Workspaces.

Reviewed by Cursor Bugbot for commit 081b385. Bugbot is set up for automated code reviews on this repo. Configure here.

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant