-
Notifications
You must be signed in to change notification settings - Fork 0
feat(fmt): enable parallel formatting #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chenjiahan
wants to merge
2
commits into
main
Choose a base branch
from
chenjiahan/feat-fmt-parallel-worker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // Derived from @prettier/cli, see THIRD_PARTY_NOTICES.md | ||
|
|
||
| import { availableParallelism } from 'node:os'; | ||
| import WorkTank from 'worktank'; | ||
|
|
||
| type FmtWorkerMethods = typeof import('./worker.ts'); | ||
|
|
||
| interface FmtWorker { | ||
| formatFile: FmtWorkerMethods['formatFileSerial']; | ||
| terminate: () => void; | ||
| } | ||
|
|
||
| const getFmtWorkerCount = (fileCount: number): number => | ||
| Math.min(fileCount, Math.max(1, availableParallelism() - 1)); | ||
|
|
||
| const getFmtWorkerUrl = (): URL => { | ||
| // Source tests run after build and exercise the same worker artifact as the CLI. | ||
| const workerPath = new URL(import.meta.url).pathname.endsWith('.ts') | ||
| ? '../../dist/fmtWorker.js' | ||
| : './fmtWorker.js'; | ||
| return new URL(workerPath, import.meta.url); | ||
| }; | ||
|
|
||
| /** Creates and starts every worker before formatting can begin. */ | ||
| const createFmtWorker = async (fileCount: number): Promise<FmtWorker> => { | ||
| const workerCount = getFmtWorkerCount(fileCount); | ||
| const pool = new WorkTank<FmtWorkerMethods>({ | ||
| pool: { | ||
| name: 'rstack-fmt', | ||
| size: workerCount, | ||
| }, | ||
| worker: { | ||
| autoInstantiate: true, | ||
| methods: getFmtWorkerUrl(), | ||
| }, | ||
| }); | ||
|
|
||
| try { | ||
| // Concurrent handshakes make WorkTank assign one task to every worker. | ||
| await Promise.all( | ||
| Array.from({ length: workerCount }, () => pool.exec('initializeFmtWorker', [])), | ||
| ); | ||
| } catch (error) { | ||
| pool.terminate(); | ||
| throw error; | ||
| } | ||
|
|
||
| return { | ||
| formatFile: (file, shouldWrite) => pool.exec('formatFileSerial', [file, shouldWrite]), | ||
| terminate: pool.terminate, | ||
| }; | ||
| }; | ||
|
|
||
| export { createFmtWorker }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| /** | ||
| * Internal build entry reserved for the fmt worker. | ||
| * | ||
| * The worker implementation is intentionally added by a later PR. Keeping a | ||
| * dedicated entry now establishes a stable published asset boundary. | ||
| */ | ||
| export {}; | ||
| import { formatFileSerial } from './serial.ts'; | ||
|
|
||
| /** Confirms that the worker module and its runtime dependencies are ready. */ | ||
| const initializeFmtWorker = (): true => true; | ||
|
|
||
| export { formatFileSerial, initializeFmtWorker }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The published formatter bundle now includes
isotimer, whose newly added dependency chain includesimmediato@1.1.0(pnpm-lock.yaml:3419-3421), but this notice lists the other WorkTank transitive packages without including immediato. Because its MIT license requires its copyright and permission notice to accompany substantial distributed copies, add immediato’s license entry before publishing the bundled package.Useful? React with 👍 / 👎.