refactor(fmt): prepare runner for multiple execution paths - #131
Conversation
📝 WalkthroughWalkthroughThe formatting runner now separates per-file execution, sequential file processing, and exit-code calculation. It records per-file duration, maps results to written, different, unchanged, or error states, and preserves input order. Exit-code calculation returns 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/rstack/src/fmt/runner.ts`:
- Around line 69-79: Export the runFmtFiles function so it can be invoked by
other modules; preserve its existing parameters, serial execution, result
construction, and timing behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 10ef89d1-eb93-4ee7-8b1d-ef9cca73a6fb
📒 Files selected for processing (1)
packages/rstack/src/fmt/runner.ts
Deploying rstack-cli with
|
| Latest commit: |
9411ada
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bec3815b.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-refactor-fmt-runn.rstack-cli.pages.dev |
Summary
Testing
pnpm --filter rstack buildpnpm --filter rstack testpnpm lintpnpm check:format