chore: migrate repository formatting to rs fmt - #125
Conversation
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0087d5e445
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "scripts": { | ||
| "build": "pnpm --filter './packages/**' build", | ||
| "check:format": "prettier . --check --experimental-cli", | ||
| "check:format": "rs fmt --check", |
There was a problem hiding this comment.
Run formatting through the source CLI before builds
On a fresh checkout after pnpm install, both formatting scripts now resolve the workspace rs binary, whose packages/rstack/bin/rs.js:16 imports the gitignored dist/index.js; because installation no longer builds that package, pnpm check:format and pnpm format fail until contributors manually run a build. Use the repository source entry point (node scripts/rs.js fmt ...) as the existing prepare script does so these documented formatting commands remain usable independently of a build.
AGENTS.md reference: AGENTS.md:L19-L23
Useful? React with 👍 / 👎.
This PR migrates the repository's formatting scripts and staged-file tasks from the standalone Prettier CLI to
rs fmt. Prettier options and ignore patterns now live underdefine.fmt, removing the separate configuration and ignore files.prettier-plugin-packagejsonremains disabled with a TODO untilrs fmtsupports project-root plugin resolution.