Type ImageLoader native module headers as a string map (#57740) - #57740
Open
rubennorte wants to merge 15 commits into
Open
Type ImageLoader native module headers as a string map (#57740)#57740rubennorte wants to merge 15 commits into
rubennorte wants to merge 15 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113781106. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
rubennorte
force-pushed
the
export-D113781106
branch
from
July 28, 2026 17:26
7696da8 to
3799268
Compare
Summary: Upgrade the legacy native module spec files from `flow` to `flow strict-local` to enforce stricter local type checking. Loose `Object` types were replaced with the codegen-equivalent `UnsafeObject`, and `Array<any>` parameters with `Array<unknown>`, both of which are codegen-identical so the generated native interfaces are unchanged. Changelog: [Internal] Differential Revision: D113763785
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
July 29, 2026 10:56
3799268 to
3b4467b
Compare
meta-codesync
Bot
changed the title
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
July 29, 2026 13:44
3b4467b to
a18ba0f
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
July 29, 2026 15:22
a18ba0f to
c00740b
Compare
Summary: Upgrade the Blob-related modules (`File`, `FileReader`, `URL`, `URLSearchParams`) from `flow` to `flow strict-local`. These expose spec-mandated getters/setters, so they opt out of the `unsafe-getters-setters` lint with a scoped `// flowlint unsafe-getters-setters:off` directive. `URL` also received small behavior-preserving refactors (local variables instead of parameter reassignment, explicit null/empty checks). Changelog: [Internal] Differential Revision: D113763778
Summary: Upgrade the StyleSheet modules from `flow` to `flow strict-local`. `processFilter` and `setNormalizedColorAlpha` required small, behavior-preserving refactors (local variables instead of reassigning function parameters, and explicit null/empty checks) to satisfy the stricter lints. Changelog: [Internal] Differential Revision: D113763790
Summary: Upgrade assorted Utilities modules from `flow` to `flow strict-local` with accurate types. `insetsDiffer` uses local variables instead of reassigning its function parameters. Behavior is unchanged. Changelog: [Internal] Differential Revision: D113763792
Summary: Upgrade assorted components from `flow` to `flow strict-local` with accurate types. `Button` replaces implicit truthiness checks with explicit comparisons that preserve the exact previous runtime behavior (no logic change). Changelog: [Internal] Differential Revision: D113763782
Summary: Upgrade `AppRegistry` (and its Flow type companion) and several Core timer modules from `flow` to `flow strict-local` with accurate types. Behavior is unchanged. Changelog: [Internal] Differential Revision: D113763781
Summary: Upgrade the element inspector dev support modules from `flow` to `flow strict-local`, replacing loose `Object`/`Function` types with the accurate types already used by their callers and dependencies. Changelog: [Internal] Differential Revision: D113763787
Summary: Upgrade several remaining Libraries modules (WebSocket, PanResponder, RCTEventEmitter, and Flow type tests) from `flow` to `flow strict-local` with accurate types. WebSocket exposes spec-mandated getters/setters and opts out of the `unsafe-getters-setters` lint with a scoped directive. Behavior is unchanged. Changelog: [Internal] Differential Revision: D113763779
Summary: Upgrade the FlatList/SectionList list components, the networking modules (`XMLHttpRequest`, `FormData`, `RCTNetworking`, `convertRequestBody`), and the UIManager modules from `flow` to `flow strict-local`. Their existing public type signatures are preserved exactly, so consumers are unaffected; internal `any`/`Object` usages were replaced with accurate types. One consumer was updated to match. Changelog: [Internal] Differential Revision: D113763786
Summary: Upgrade the remaining ReactNative and Core modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Genuinely-dynamic internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]` where an accurate type cannot be expressed. Changelog: [Internal] Differential Revision: D113763791
Summary: Upgrade `deepDiffer`, `codegenNativeCommands`, `Dimensions`, and `ReactNativeTestTools` from `flow` to `flow strict-local`, preserving public type signatures. These operate on values of arbitrary shape, so the unavoidable internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Differential Revision: D113763789
Summary: Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Differential Revision: D113763793
Summary: Upgrade `processTransform` from `flow` to `flow strict-local`, preserving its public type signature. Mechanical violations were fixed accurately; arbitrary-shape internal values are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Differential Revision: D113763784
Summary: Upgrade the remaining assorted modules (Touchable pooling, ActionSheetIOS, Alert, LogBox highlight, Text native component, PushNotificationIOS) from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Genuinely-dynamic internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]` where an accurate type cannot be expressed. Changelog: [Internal] Differential Revision: D113763783
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
July 29, 2026 16:46
c00740b to
ae54e4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
getSizeWithHeaderson the ImageLoader native modules typed itsheadersparameter as the opaqueUnsafeObject. HTTP headers are a homogeneous string-to-string map, so type them as{[key: string]: string}instead. This is codegen-compatible and emits the same native type (NSDictionary/ReadableMap/jsi::Object), so there is no change to the native interface — it only adds value-type validation on the JavaScript side.Other
UnsafeObjectusages in these specs (e.g.queryCache's result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic.Changelog: [Internal]
Reviewed By: huntie
Differential Revision: D113781106