Skip to content

ci: fix React Doctor workflow - #644

Merged
zombieJ merged 1 commit into
masterfrom
fix/react-doctor-workflow-v2.2.8
Jul 31, 2026
Merged

ci: fix React Doctor workflow#644
zombieJ merged 1 commit into
masterfrom
fix/react-doctor-workflow-v2.2.8

Conversation

@yoyo837

@yoyo837 yoyo837 commented Jul 31, 2026

Copy link
Copy Markdown
Member
  • add push trigger for the default branch
  • grant issues: write and statuses: write permissions
  • fetch full Git history (fetch-depth: 0)
  • update action pin to v2.2.8
  • remove obsolete github-token input where applicable

Context

react-component/table#1503

Summary by CodeRabbit

  • 改进
    • React Doctor 检查现已在推送到 master 分支时自动运行。
    • 优化了检查流程的权限配置和历史记录获取方式。
    • 更新了 React Doctor 检查版本,提升流程稳定性。

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
trigger Ready Ready Preview Jul 31, 2026 9:51am

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

React Doctor 工作流新增 master 推送触发器。工作流权限、Git 检出深度和 React Doctor Action 提交版本也已更新。

Changes

React Doctor 工作流

Layer / File(s) Summary
工作流触发与执行配置
.github/workflows/react-doctor.yml
工作流响应 master 推送,并获得 issues 和 commit statuses 的写权限。Checkout 使用 fetch-depth: 0。React Doctor Action 更新到新的提交。

Estimated code review effort: 2 (简单) | ~10 分钟

Poem

我是小兔,背着新流程,
master 一推,我便出动。
历史完整,权限清楚,
Doctor 新版踏上旅途。
胡萝卜旁,检查成功。

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题明确说明了 React Doctor CI 工作流的修复,与变更内容直接相关。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/react-doctor-workflow-v2.2.8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/react-doctor.yml (1)

27-27: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

为固定 SHA 添加版本注释。

完整 SHA 可以固定供应链版本。请追加 # v2.2.8,便于维护者直接核对版本与提交。官方发布页显示 v2.2.8 对应此提交。 (github.com)

建议修改
-      - uses: millionco/react-doctor@01820bb4fd4d0a4aebcd8df2b2a143a098649cb2
+      - uses: millionco/react-doctor@01820bb4fd4d0a4aebcd8df2b2a143a098649cb2 # v2.2.8
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/react-doctor.yml at line 27, 在 react-doctor 的 uses
配置行追加版本注释“# v2.2.8”,保留现有完整 SHA 不变,以便维护者核对固定提交对应的版本。

Source: MCP tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/react-doctor.yml:
- Line 27: 在 react-doctor 的 uses 配置行追加版本注释“# v2.2.8”,保留现有完整 SHA
不变,以便维护者核对固定提交对应的版本。

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e6b62326-71ea-4d36-9fee-d642faef8172

📥 Commits

Reviewing files that changed from the base of the PR and between db7e6aa and c1f1dec.

📒 Files selected for processing (1)
  • .github/workflows/react-doctor.yml

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.28%. Comparing base (db7e6aa) to head (c1f1dec).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #644   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files          17       17           
  Lines         958      958           
  Branches      270      280   +10     
=======================================
  Hits          932      932           
  Misses         26       26           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown

❌ Deploy failed

PR preview ❌ Failed ❌ Failed
🔗 Preview https://react-component-trigger-preview-pr-644.surge.sh (may be unavailable)
📝 Commitc1f1dec
🪵 LogsView logs
📋 Build log (last lines)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^3 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9.7" from eslint-plugin-react@7.37.5
npm error node_modules/eslint-plugin-react
npm error   dev eslint-plugin-react@"^7.37.5" from the root project
npm error   eslint-plugin-react@"^7.32.2" from @umijs/fabric@4.0.1
npm error   node_modules/@umijs/fabric
npm error     @umijs/fabric@"^4.0.0" from rc-test@7.1.3
npm error     node_modules/rc-test
npm error       dev rc-test@"^7.1.3" from the root project
npm error
npm error Conflicting peer dependency: eslint@9.39.5
npm error node_modules/eslint
npm error   peer eslint@"^3 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9.7" from eslint-plugin-react@7.37.5
npm error   node_modules/eslint-plugin-react
npm error     dev eslint-plugin-react@"^7.37.5" from the root project
npm error     eslint-plugin-react@"^7.32.2" from @umijs/fabric@4.0.1
npm error     node_modules/@umijs/fabric
npm error       @umijs/fabric@"^4.0.0" from rc-test@7.1.3
npm error       node_modules/rc-test
npm error         dev rc-test@"^7.1.3" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /home/runner/.npm/_logs/2026-07-31T09_44_36_183Z-eresolve-report.txt
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2026-07-31T09_44_36_183Z-debug-0.log

🤖 Powered by surge-preview

@zombieJ
zombieJ merged commit 3ff7d68 into master Jul 31, 2026
13 checks passed
@zombieJ
zombieJ deleted the fix/react-doctor-workflow-v2.2.8 branch July 31, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants