feat(billing): move plan writes to AdminService and add ListAllPlans - #1830
Draft
rohilsurana wants to merge 6 commits into
Draft
feat(billing): move plan writes to AdminService and add ListAllPlans#1830rohilsurana wants to merge 6 commits into
rohilsurana wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wire the frontier side of the plan admin APIs from raystack/proton#496.
CreatePlanandUpdatePlantoAdminService(super user only). They were onFrontierServicebefore.ListAllPlansonAdminService. It lists every plan, including disabled ones. An empty state returns all plans; a set state filters to it.CreatePlannow carries the planstate.UpdatePlanis implemented (it returnedUnimplementedbefore) and does a full write of a plan's own fields (title, description, credits, trial days, state, metadata). A plan's products are still managed throughCreatePlan's upsert.ListPlansandGetPlanstay onFrontierServiceand are unchanged.How
ConnectHandlerserves both services, so the existingCreatePlanmethod now satisfiesAdminService.UpdatePlanandListAllPlansare added to it.AdminServiceplan RPCs behindIsSuperUser, and the oldFrontierServiceplan entries are removed. Any endpoint not listed is denied by default, so these entries are required.ListAllPlanspasses aplan.StateAllsentinel to the repository so an empty state lists plans in every state. The repository still defaults an empty state to active forListPlans, which lists active plans only.Depends on
Testing
UpdatePlanandListAllPlans. Existing plan handler and service tests pass.CreatePlanon the admin client.