gh-155041: Support copy.replace() for decimal.Context - #155047
Merged
serhiy-storchaka merged 2 commits intoAug 2, 2026
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Documentation build overview
|
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
skirpichev
approved these changes
Aug 2, 2026
Comment on lines
+1731
to
+1738
| prec: object = NULL | ||
| rounding: object = NULL | ||
| Emin as emin: object = NULL | ||
| Emax as emax: object = NULL | ||
| capitals: object = NULL | ||
| clamp: object = NULL | ||
| flags as status: object = NULL | ||
| traps: object = NULL |
Member
There was a problem hiding this comment.
The problem with NULL defaults, is that this not supported by inspect.signature(), rendered as "unrepresentable".
But perhaps it for another day, we have other examples in the decimal module. Using a sentinel might be an option.
Member
Author
There was a problem hiding this comment.
This is why we use @text_signature "($self, /, **changes)" like for all other __replace__ methods.
Member
There was a problem hiding this comment.
This is a workaround, yes. Hence, PR was approved.
But I think that explicit arguments would be better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Context.__replace__()in both implementations, so thatcopy.replace()returns a duplicate of the context with the specified fields replaced. Fields which are not specified keep the values they have in the original context.