gh-154948: Fix test_zipfile failure when SOURCE_DATE_EPOCH is set - #155001
Open
StanFromIreland wants to merge 1 commit into
Open
gh-154948: Fix test_zipfile failure when SOURCE_DATE_EPOCH is set#155001StanFromIreland wants to merge 1 commit into
test_zipfile failure when SOURCE_DATE_EPOCH is set#155001StanFromIreland wants to merge 1 commit into
Conversation
Additionally, move the `SOURCE_DATE_EPOCH` test helpers from `test_py_compile` to `test.support.os_helper`.
StanFromIreland
requested review from
FFY00,
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
July 31, 2026 18:03
Member
Author
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, move the
SOURCE_DATE_EPOCHtest helpers fromtest_py_compiletotest.support.os_helper, and refactor a little intest_zipfileandtest_randomto use them instead of duplicate helpers (they were already used bytest_importlibandtest_compileall).