gh-151728: Partially revert "Clear the typing caches at interpreter shutdown (GH-154858)" - #154992
Merged
Conversation
…own (pythonGH-154858)" Unfortunately, this change causes reference leak tests to fail.
JelleZijlstra
approved these changes
Jul 31, 2026
Contributor
|
@encukou Can you tell me where those leak test failures can be seen? The original PR afaik had no test failures. |
Member
Author
|
Refleak tests take a long time, so they aren't run on GHA, but post-merge on Buildbot. You can see them here: https://buildbot.python.org/#/release_status Or locally, using: ./python -m test test_typing -R:(see |
Member
|
Example failing build https://buildbot.python.org/#/builders/1610/builds/3766 I'm guessing the issue is we reload |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, adding the
atexitfunction causes reference leak tests to fail.Broken Tier 1 buildbots, revert or fix immediatelly. I currently don't have time to investigate.
This only reverts the atexit registration: it leaves the
_clear_cachesfunction, to simplify the regrtest utils code a bit.cc @wjakob
typingcaches keep extension types alive past shutdown #151728