Android fixes - #154895
Merged
Merged
Conversation
Member
|
Can you have a better title? it does not really say what it does |
mhsmith
added
skip issue
skip news
needs backport to 3.13
Member
Author
|
Sorry, description updated. There isn't really a better title, since the only thing these bugs have in common is Android, but since they're all very small, I thought it was better to put them all in the same PR to avoid multiplying the backports. |
Documentation build overview
|
freakboy3742
approved these changes
Jul 30, 2026
freakboy3742
left a comment
freakboy3742
left a comment
Contributor
There was a problem hiding this comment.
All makes sense to me. 👍
|
Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-154905 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-154906 is a backport of this pull request to the 3.14 branch. |
|
GH-154907 is a backport of this pull request to the 3.13 branch. |
freakboy3742
pushed a commit
that referenced
this pull request
Jul 30, 2026
A collection of small cleanups for Android support: * Clarifies the documentation around version number handling for iOS and Android in os.uname and platform.release * Ensures that automated NDK installs surface messages written to stderr * Makes the Android NDK check more robust for incomplete downloads * Corrects some linting errors in Android build scripts (cherry picked from commit f4b1d3e) Co-authored-by: Malcolm Smith <smith@chaquo.com>
freakboy3742
pushed a commit
that referenced
this pull request
Jul 30, 2026
A collection of small cleanups for Android support: * Clarifies the documentation around version number handling for iOS and Android in os.uname and platform.release * Ensures that automated NDK installs surface messages written to stderr * Makes the Android NDK check more robust for incomplete downloads * Corrects some linting errors in Android build scripts (cherry picked from commit f4b1d3e) Co-authored-by: Malcolm Smith <smith@chaquo.com>
freakboy3742
pushed a commit
that referenced
this pull request
Jul 30, 2026
A collection of small cleanups for Android support: * Clarifies the documentation around version number handling for iOS and Android in os.uname and platform.release * Ensures that automated NDK installs surface messages written to stderr * Makes the Android NDK check more robust for incomplete downloads * Corrects some linting errors in Android build scripts (cherry picked from commit f4b1d3e) Co-authored-by: Malcolm Smith <smith@chaquo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that the user-facing Android and iOS versions can be found in
platform.release, notplatform.version, which is a kernel build number that's much less likely to be useful.Don't capture stderr from android-env.py. This allows it to display the message "Installing NDK - this may take several minutes", which is quite important, otherwise the user will probably think the script has hung.
Previously the NDK was detected only by checking for the existence of its directory, which will be left in an unusable state by interrupted installations. Fixed by checking for the package.xml file, which sdkmanager creates after installation is complete.
Fix a couple of warnings found by linters: use of an undefined
payloadvariable inAndroid/__main__.py, and defining an unuseditvariable inMainActivity.kt.