Skip to content

gh-154738: Propagate reparse-deferral setting to pyexpat subparsers - #154739

Merged
encukou merged 1 commit into
python:mainfrom
tonghuaroot:pyexpat-subparser-reparse-deferral
Jul 31, 2026
Merged

gh-154738: Propagate reparse-deferral setting to pyexpat subparsers#154739
encukou merged 1 commit into
python:mainfrom
tonghuaroot:pyexpat-subparser-reparse-deferral

Conversation

@tonghuaroot

@tonghuaroot tonghuaroot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

ExternalEntityParserCreate copied every parent field onto the subparser except reparse_deferral_enabled. PyObject_GC_New does not zero the struct, so the field was read uninitialized and GetReparseDeferralEnabled() returned garbage. Copy it from the parent, matching newxmlparseobject and Expat's own inherited C-level state.

@encukou

encukou commented Jul 31, 2026

Copy link
Copy Markdown
Member

Thank you!

@encukou
encukou merged commit 7d76013 into python:main Jul 31, 2026
60 checks passed
@encukou encukou added awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 31, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @tonghuaroot for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @tonghuaroot for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

Copy link
Copy Markdown

Thanks @tonghuaroot for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 31, 2026

Copy link
Copy Markdown

GH-154989 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 31, 2026
@bedevere-app

bedevere-app Bot commented Jul 31, 2026

Copy link
Copy Markdown

GH-154990 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 31, 2026
@bedevere-app

bedevere-app Bot commented Jul 31, 2026

Copy link
Copy Markdown

GH-154991 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants