Reference the original chain in ExistingArrayDimFetch, delete DeepNodeCloner - #6151
Merged
Conversation
…eCloner The unset() handling deep-cloned the already-processed offset chain and ran a NodeTraverser over the clone to wrap its levels in ExistingArrayDimFetch nodes. The wrappers now reference the original sub-expressions directly - the unset statement's own walk already processed them, and the assign target preparation prices the chain through the scope without walking it, so nothing re-processes the shared nodes. DeepNodeCloner had no other consumer. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DaBZjgksga4c5s6Q9FniY7
ondrejmirtes
force-pushed
the
eadf-originals
branch
from
July 30, 2026 15:43
3c5547f to
b8b3585
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from the resolve-type-rewrite-2 branch: the
unset()handling deep-cloned the already-processed offset chain plus ran a NodeTraverser visitor over the clone just to wrap its levels inExistingArrayDimFetchnodes. The wrappers now reference the original sub-expressions - the unset statement's own walk already processed them, and the assign target preparation prices the chain through the scope without walking it (scope-keyed memoization), so sharing the nodes is safe.DeepNodeClonerhad no other consumer and is deleted along with its five construction sites.Full test suite,
make phpstanandmake csgreen; zero analysis-output churn.🤖 Generated with Claude Code
https://claude.ai/code/session_01DaBZjgksga4c5s6Q9FniY7