Extract the intrinsic closure-parameter blocks into applyIntrinsicArgOverrides() - #6149
Merged
Conversation
…rSelector::applyIntrinsicArgOverrides() A pure move: the four blocks (array_map, array_filter/find, array_walk/ uasort-like, immediately-invoked) leave selectFromArgs() into a named method that reads argument types through injected getters. Verified byte-identical to the inline region modulo the getter indirection. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DaBZjgksga4c5s6Q9FniY7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure move, extracted from the resolve-type-rewrite-2 branch: the intrinsic closure-parameter blocks leave
selectFromArgs()intoParametersAcceptorSelector::applyIntrinsicArgOverrides(), reading argument types through injected getter closures. The method body is byte-identical to the former inline region modulo the getter indirection (verified mechanically), andselectFromArgs()passes$scope-backed getters, so behavior is unchanged.Full test suite,
make phpstanandmake csgreen; zero analysis-output churn.🤖 Generated with Claude Code
https://claude.ai/code/session_01DaBZjgksga4c5s6Q9FniY7