Skip to content

ext/session: report a rejected session cookie header #22923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iliaal wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
+33 −2
Open

ext/session: report a rejected session cookie header #22923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/session/session.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1497,10 +1497,10 @@ static zend_result php_session_send_cookie(void) /* {{{ */
php_session_remove_cookie(); /* remove already sent session ID cookie */
/* 'replace' must be 0 here, else a previous Set-Cookie
header, probably sent with setcookie() will be replaced! */
sapi_add_header_ex(estrndup(ZSTR_VAL(ncookie.s), ZSTR_LEN(ncookie.s)), ZSTR_LEN(ncookie.s), 0, 0);
zend_result result = sapi_add_header_ex(estrndup(ZSTR_VAL(ncookie.s), ZSTR_LEN(ncookie.s)), ZSTR_LEN(ncookie.s), 0, 0);
smart_str_free(&ncookie);

return SUCCESS;
return result;
}
/* }}} */

Expand Down
31 changes: 31 additions & 0 deletions ext/session/tests/session_start_cookie_header_rejected.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
--TEST--
session_start() when the SAPI rejects the session cookie header
--INI--
session.save_handler=files
session.name=PHPSESSID
session.gc_probability=0
--EXTENSIONS--
session
--FILE--
<?php

ob_start();

set_error_handler(function (int $errno, string $errstr): bool {
echo "handler: ", $errstr, PHP_EOL;
if (session_status() === PHP_SESSION_ACTIVE) {
session_destroy();
}
return true;
});

session_set_cookie_params(['path' => "/\r\nX-Injected: yes"]);

var_dump(session_start());
var_dump(session_status() === PHP_SESSION_NONE);

?>
--EXPECT--
handler: Header may not contain more than a single header, new line detected
bool(false)
bool(true)
Loading