Conversation
There was a problem hiding this comment.
Pull request overview
This PR reworks the ohmyzsh/zsh image to compile Zsh directly from the upstream zsh-users/zsh repository (instead of inheriting from zshusers/zsh), and updates CI/tagging to reflect the new build approach.
Changes:
- Replace the
zshimage base with a multi-stage build that clones and compiles Zsh from source. - Update
zsh/README.mdto reflect that the image no longer bundles Oh My Zsh. - Adjust the GitHub Actions workflow to include Zsh 5.9.1 (and additional 4.3.x tags) and add safety conditionals around Docker Hub login.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
zsh/Dockerfile |
Switches to a Debian-based multi-stage build that compiles and installs Zsh artifacts into the runtime image. |
zsh/README.md |
Updates documentation to describe the new “Zsh-only” image contents and examples. |
zsh/sources.list |
Removes the old Debian Buster archive sources usage for the zsh image. |
.github/workflows/main.yml |
Updates Zsh version matrix/latest version and adjusts job/step gating for Docker Hub operations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
carlosala
marked this pull request as ready for review
June 29, 2026 10:53
carlosala
changed the title
zsh ourselveszsh and use debian trixie
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.