Skip to content

src: fix heap value deduplication in embedder graph - #64801

Open
IlyasShabi wants to merge 1 commit into
nodejs:mainfrom
IlyasShabi:ishabi/embedder-graph-deduplication
Open

src: fix heap value deduplication in embedder graph#64801
IlyasShabi wants to merge 1 commit into
nodejs:mainfrom
IlyasShabi:ishabi/embedder-graph-deduplication

Conversation

@IlyasShabi

Copy link
Copy Markdown
Member

This PR aims to fix an embedder graph bug introduced by #52295, where distinct V8 values could be treated as the same graph node.

It uses an explicit value lookup for deduplication and extends the internal test binding to expose V8 values for regression testing.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 28, 2026
Signed-off-by: ishabi <ilyasshabi94@gmail.com>
@IlyasShabi
IlyasShabi force-pushed the ishabi/embedder-graph-deduplication branch from bc8ffc2 to d62e941 Compare July 28, 2026 10:09
@IlyasShabi
IlyasShabi marked this pull request as ready for review July 28, 2026 10:17
@IlyasShabi
IlyasShabi requested a review from joyeecheung July 28, 2026 10:17
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (4bec191) to head (d62e941).
⚠️ Report is 78 commits behind head on main.

Files with missing lines Patch % Lines
src/heap_utils.cc 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64801      +/-   ##
==========================================
+ Coverage   90.13%   90.14%   +0.01%     
==========================================
  Files         741      744       +3     
  Lines      242106   242542     +436     
  Branches    45551    45692     +141     
==========================================
+ Hits       218211   218648     +437     
+ Misses      15430    15394      -36     
- Partials     8465     8500      +35     
Files with missing lines Coverage Δ
src/heap_utils.cc 80.61% <86.66%> (+1.36%) ⬆️

... and 93 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants