ci: always run "./update.sh" even if musl is missing - #2581
Draft
nschonni wants to merge 1 commit into
Draft
Conversation
- swap calls to `fuction.sh` for normal Node.js file operations - Assume the Alpine build might lag - Read the `security` flag from nodejs.org instead of unofficial-builds
nschonni
commented
Jul 29, 2026
| ); | ||
|
|
||
| const supportedVersions = versionsOutput.trim().split(' '); | ||
| let files = readdirSync('./'); |
Member
Author
There was a problem hiding this comment.
Think this probably needs to use something like import.meta.dirname
Member
Author
There was a problem hiding this comment.
Also used the Sync versions of the methods that probably should be swapped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Security releases are still getting stuck on Unofficial builds, so ensure that the
securityflag is read from the nodejs.orgindex.json, not the unofficial-builds version, that is missing till the build is queued.Motivation and Context
fuction.shfor normal Node.js file operationssecurityflag from nodejs.org instead of unofficial-buildsTesting Details
Example Output(if appropriate)
Types of changes
Checklist