Skip to content

ci: always run "./update.sh" even if musl is missing - #2581

Draft
nschonni wants to merge 1 commit into
nodejs:mainfrom
nschonni:build-js
Draft

ci: always run "./update.sh" even if musl is missing#2581
nschonni wants to merge 1 commit into
nodejs:mainfrom
nschonni:build-js

Conversation

@nschonni

@nschonni nschonni commented Jul 29, 2026

Copy link
Copy Markdown
Member

Description

Security releases are still getting stuck on Unofficial builds, so ensure that the security flag is read from the nodejs.org index.json, not the unofficial-builds version, that is missing till the build is queued.

Motivation and Context

  • swap calls to fuction.sh for normal Node.js file operations
  • removed assumptions that it only runs on GitHub Actions, and use native Node.js Fetch instead
  • Assume the Alpine build might lag
  • Read the security flag from nodejs.org instead of unofficial-builds

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

- swap calls to `fuction.sh` for normal Node.js file operations
- Assume the Alpine build might lag
- Read the `security` flag from nodejs.org instead of unofficial-builds
Comment thread build-automation.mjs
);

const supportedVersions = versionsOutput.trim().split(' ');
let files = readdirSync('./');

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this probably needs to use something like import.meta.dirname

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also used the Sync versions of the methods that probably should be swapped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant