[stable34] fix(unified-search): catch errors in response - #62616
Open
leftybournes wants to merge 2 commits into
Open
[stable34] fix(unified-search): catch errors in response#62616leftybournes wants to merge 2 commits into
leftybournes wants to merge 2 commits into
Conversation
leftybournes
requested review from
kristian-zendato,
nfebe and
skjnldsv
and removed request for
a team
July 28, 2026 13:51
leftybournes
changed the title
susnux
approved these changes
Jul 28, 2026
icewind1991
approved these changes
Jul 28, 2026
Member
Author
|
/compile rebase |
leftybournes
enabled auto-merge
July 29, 2026 00:13
nextcloud-command
force-pushed
the
leftybournes/stable34/fix/unifiedsearch-catch-errors
branch
from
July 29, 2026 00:21
68c74a9 to
d3dac32
Compare
Signed-off-by: Kent Delante <kent@delante.me> When an error response is returned by the unified search api, unified search shows an endless "Searching" message. This catches the error and sets the modal into a non-searching state so it no longer endlessly shows the message.
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
leftybournes
force-pushed
the
leftybournes/stable34/fix/unifiedsearch-catch-errors
branch
from
July 29, 2026 00:25
d3dac32 to
96f1698
Compare
Member
Author
|
Failing tests are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an error response is returned by the unified search api, unified search shows an endless "Searching" message. This catches the error and sets the modal into a non-searching state so it no longer endlessly shows the message.
Not a backport
Based on #61437
Checklist
3. to review, feature component)stable32)AI (if applicable)