Skip to content

✨ Improve FoMaC and embedded QDMI integration - #1957

Draft
burgholzer wants to merge 6 commits into
mainfrom
agent/core-cudaq-qdmi-integration
Draft

✨ Improve FoMaC and embedded QDMI integration#1957
burgholzer wants to merge 6 commits into
mainfrom
agent/core-cudaq-qdmi-integration

Conversation

@burgholzer

Copy link
Copy Markdown
Member

🤖 AI text below 🤖

Summary

  • add exact-byte FoMaC submission and retrieval for binary QDMI programs
  • expose the complete standard QDMI program-format enum in Python and enforce text/binary representation contracts
  • let embedded consumers independently select the QIR runner and DDSIM QIR support while reusing existing LLVM/MLIR and spdlog targets
  • advertise the binary FoMaC API and DDSIM QIR capability through exported target properties
  • exercise source-tree embedding, textual QASM, and real QIR bitcode paths

Context

This is an independent prerequisite for the QDMI integration in NVIDIA/cuda-quantum#4882. It does not depend on #1912 and can merge separately. Stable-ID device registration and selective provider composition remain part of #1912.

Validation

  • full release build with LLVM/MLIR 22.1.3
  • 170/170 native FoMaC tests
  • 47/47 DDSIM QDMI device tests
  • 7/7 nested CMake consumer tests across source and imported-package dependency modes
  • 9/9 focused Python FoMaC tests, including real QIR bitcode execution
  • stub generation
  • full repository lint

Preserve exact byte payloads for binary QDMI programs while retaining null-terminated text submission. Expose byte submission and retrieval in Python and exercise a real QIR module through DDSIM.

Assisted-by: GPT-5.6 via Codex
Allow DDSIM's QIR JIT to reuse a parent LLVM/MLIR installation without building MQT Core's compiler dialects. Reuse parent-provided spdlog targets, export capability properties, and verify the configuration with a nested consumer build.

Assisted-by: GPT-5.6 via Codex
Assisted-by: GPT-5.6 via Codex
Assisted-by: GPT-5.6 via Codex
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fomac/FoMaC.cpp 93.5% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Assisted-by: GPT-5.6 via Codex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant