Add Vally evaluation harness for Event Hubs tools - #3159
Draft
LarryOsterman wants to merge 13 commits into
Draft
Conversation
…ports can be generated without running eval
Add servers/Azure.Mcp.Server/tests/Vally with Invoke-VallyEval.ps1 discovery-based runner, README, and first Event Hubs experiment (eventhub-get, namespace-get) with baseline/treatment eval specs and provisioning scripts. Update cspell dictionary and CHANGELOG.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
LarryOsterman
requested review from
JasonYeMSFT,
RickWinter,
chidozieononiwu,
g2vinay,
saikoumudi,
tmeschter and
vukelich
July 24, 2026 23:45
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
LarryOsterman
marked this pull request as draft
July 24, 2026 23:46
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Vally-based evaluation harness under servers/Azure.Mcp.Server/tests/Vally to measure agent effectiveness for Azure MCP Event Hubs tools using baseline vs treatment experiment variants, including optional per-area Azure provisioning/teardown scripts.
Changes:
- Added a discovery-based PowerShell runner (
Invoke-VallyEval.ps1) to buildazmcp, discover experiments, provision resources per area, run experiments (optionally multiple iterations), and summarize baseline vs treatment outcomes. - Added Event Hubs evaluation specs (
*.eval.yaml) and experiments (*.experiment.yaml) foreventhubs_eventhub_getandeventhubs_namespace_get, plus provisioning/teardown scripts using Azure CLI. - Updated repo metadata (
CHANGELOG.md,.vscode/cspell.json, and a local.gitignore) to document and support the new harness.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| servers/Azure.Mcp.Server/tests/Vally/README.md | Documents the Vally harness layout, runner usage, and how baseline vs treatment comparisons are interpreted. |
| servers/Azure.Mcp.Server/tests/Vally/Invoke-VallyEval.ps1 | Implements experiment discovery, build/PATH setup, optional provisioning, execution, and results summarization. |
| servers/Azure.Mcp.Server/tests/Vally/eventhubs/New-EventHubsResources.ps1 | Provisions Event Hubs resources used by the eval prompts, with DeleteAfter tagging. |
| servers/Azure.Mcp.Server/tests/Vally/eventhubs/Remove-EventHubsResources.ps1 | Tears down provisioned resources by deleting the resource group. |
| servers/Azure.Mcp.Server/tests/Vally/eventhubs/eventhub-get.experiment.yaml | Defines baseline vs treatment variants for the Event Hub “get” capability. |
| servers/Azure.Mcp.Server/tests/Vally/eventhubs/eventhub-get.eval.yaml | Defines stimuli and outcome-based LLM judge grading for Event Hub “get” scenarios. |
| servers/Azure.Mcp.Server/tests/Vally/eventhubs/namespace-get.experiment.yaml | Defines baseline vs treatment variants for the namespace “get/list” capability. |
| servers/Azure.Mcp.Server/tests/Vally/eventhubs/namespace-get.eval.yaml | Defines stimuli and outcome-based LLM judge grading for namespace “get/list” scenarios. |
| servers/Azure.Mcp.Server/tests/Vally/.gitignore | Ignores local Vally result artifacts directories. |
| servers/Azure.Mcp.Server/CHANGELOG.md | Adds an “Other Changes” entry documenting the new Vally harness and initial experiments. |
| .vscode/cspell.json | Adds new dictionary words related to Vally and Event Hubs eval content. |
Comment on lines
+55
to
+59
| if ($LASTEXITCODE -ne 0) { | ||
| # Check for errors (user not logged in, invalid subscription, etc.) | ||
| Write-Warn "Failed to check if resource group '$ResourceGroup' exists. Verify 'az login' and subscription." | ||
| exit 1 | ||
| } |
Contributor
There was a problem hiding this comment.
Fixed in 2c00671: replaced exit 1 with throw so failures propagate as exceptions and the runner can execute cleanup in finally.
Comment on lines
+104
to
+120
| .PARAMETER PreEvalScript | ||
| Optional path to a provisioning script run BEFORE the experiments of an area (e.g. | ||
| ./eventhubs/New-EventHubsResources.ps1). Use it to create the Azure resources the | ||
| eval prompts reference. -ResourceGroup and -Subscription are forwarded to it. | ||
|
|
||
| If not specified (and -SkipProvisioning is not set), the runner auto-discovers a | ||
| convention-named `New-*Resources.ps1` script in each area directory and uses that. | ||
|
|
||
| .PARAMETER PostEvalScript | ||
| Optional path to a teardown script run AFTER an area's experiments (e.g. | ||
| ./eventhubs/Remove-EventHubsResources.ps1). It runs in a finally block, so it | ||
| executes even if the run or the pre-eval provisioning fails. -ResourceGroup and | ||
| -Subscription are forwarded to it. | ||
|
|
||
| If not specified (and -SkipProvisioning is not set), the runner auto-discovers a | ||
| convention-named `Remove-*Resources.ps1` script in each area directory and uses | ||
| that. |
Contributor
There was a problem hiding this comment.
Fixed in 2c00671: removed the duplicated .PARAMETER PreEvalScript and .PARAMETER PostEvalScript blocks from comment-based help.
Comment on lines
+20
to
+24
| |-- eventhubs/ # An AREA (one subfolder per namespace) | ||
| | |-- eventhub-get.experiment.yaml # <tool>.experiment.yaml - defines baseline+treatment variants (required) | ||
| | |-- eventhub-get.eval.yaml # <tool>.eval.yaml - the shared eval spec both variants run (required) | ||
| | |-- New-EventHubsResources.ps1 # New-*Resources.ps1 - per-area provisioning (optional) | ||
| | |-- Remove-EventHubsResources.ps1 # Remove-*Resources.ps1 - per-area teardown (optional) |
Comment on lines
+33
to
+36
| The first area, `eventhubs/`, evaluates the **get Event Hub** tool | ||
| (`eventhubs_eventhub_get`). Its `eventhub-get.experiment.yaml` runs the shared | ||
| `eventhub-get.eval.yaml` as two variants that differ only in whether the Azure MCP | ||
| server is present: |
…arryOsterman/mcp into larryo/first_vally_evaluations
# Conflicts: # servers/Azure.Mcp.Server/tests/Vally/Invoke-VallyEval.ps1 # servers/Azure.Mcp.Server/tests/Vally/README.md # servers/Azure.Mcp.Server/tests/Vally/eventhubs/eventhub-get.eval.yaml # servers/Azure.Mcp.Server/tests/Vally/eventhubs/eventhub-get.experiment.yaml # servers/Azure.Mcp.Server/tests/Vally/eventhubs/namespace-get.eval.yaml # servers/Azure.Mcp.Server/tests/Vally/eventhubs/namespace-get.experiment.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a first Vally evaluation harness under servers/Azure.Mcp.Server/tests/Vally, covering the �venthubs_eventhub_get and �venthubs_namespace_get tools.
This content was migrated from the larryo/first_vally_evaluations branch in the fork larryosterman/mcp.
Invoking Livetests
Copilot submitted PRs are not trustworthy by default. Users with write access to the repo need to validate the contents of this PR before leaving a comment with the text /azp run mcp - pullrequest - live. This will trigger the necessary livetest workflows to complete required validation.