Skip to content

Add Vally evaluation harness for Event Hubs tools - #3159

Draft
LarryOsterman wants to merge 13 commits into
mainfrom
larryo/first_vally_evaluations
Draft

Add Vally evaluation harness for Event Hubs tools#3159
LarryOsterman wants to merge 13 commits into
mainfrom
larryo/first_vally_evaluations

Conversation

@LarryOsterman

Copy link
Copy Markdown
Member

Summary

Adds a first Vally evaluation harness under servers/Azure.Mcp.Server/tests/Vally, covering the �venthubs_eventhub_get and �venthubs_namespace_get tools.

  • Invoke-VallyEval.ps1: discovery-based runner that walks the directory for evaluations organized by area (namespace subfolder) and tool (.experiment.yaml).
  • Each experiment runs a shared eval spec (.eval.yaml) as two variants -- baseline (without the Azure MCP server) and treatment (with it) -- to isolate the server's contribution, graded identically via outcome-based LLM-judge graders.
  • �venthubs/New-EventHubsResources.ps1 / Remove-EventHubsResources.ps1: provisioning scripts for the Event Hubs area (tagged with DeleteAfter, local auth disabled for Safe Secrets Standard compliance).
  • Updated .vscode/cspell.json with new dictionary terms and CHANGELOG.md with an entry under Other Changes.

This content was migrated from the larryo/first_vally_evaluations branch in the fork larryosterman/mcp.

Invoking Livetests

Copilot submitted PRs are not trustworthy by default. Users with write access to the repo need to validate the contents of this PR before leaving a comment with the text /azp run mcp - pullrequest - live. This will trigger the necessary livetest workflows to complete required validation.

LarryOsterman and others added 8 commits July 8, 2026 14:36
Add servers/Azure.Mcp.Server/tests/Vally with Invoke-VallyEval.ps1 discovery-based
runner, README, and first Event Hubs experiment (eventhub-get, namespace-get)
with baseline/treatment eval specs and provisioning scripts. Update cspell
dictionary and CHANGELOG.md.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 24, 2026 23:45
@LarryOsterman
LarryOsterman requested review from a team as code owners July 24, 2026 23:45
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Vally-based evaluation harness under servers/Azure.Mcp.Server/tests/Vally to measure agent effectiveness for Azure MCP Event Hubs tools using baseline vs treatment experiment variants, including optional per-area Azure provisioning/teardown scripts.

Changes:

  • Added a discovery-based PowerShell runner (Invoke-VallyEval.ps1) to build azmcp, discover experiments, provision resources per area, run experiments (optionally multiple iterations), and summarize baseline vs treatment outcomes.
  • Added Event Hubs evaluation specs (*.eval.yaml) and experiments (*.experiment.yaml) for eventhubs_eventhub_get and eventhubs_namespace_get, plus provisioning/teardown scripts using Azure CLI.
  • Updated repo metadata (CHANGELOG.md, .vscode/cspell.json, and a local .gitignore) to document and support the new harness.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
servers/Azure.Mcp.Server/tests/Vally/README.md Documents the Vally harness layout, runner usage, and how baseline vs treatment comparisons are interpreted.
servers/Azure.Mcp.Server/tests/Vally/Invoke-VallyEval.ps1 Implements experiment discovery, build/PATH setup, optional provisioning, execution, and results summarization.
servers/Azure.Mcp.Server/tests/Vally/eventhubs/New-EventHubsResources.ps1 Provisions Event Hubs resources used by the eval prompts, with DeleteAfter tagging.
servers/Azure.Mcp.Server/tests/Vally/eventhubs/Remove-EventHubsResources.ps1 Tears down provisioned resources by deleting the resource group.
servers/Azure.Mcp.Server/tests/Vally/eventhubs/eventhub-get.experiment.yaml Defines baseline vs treatment variants for the Event Hub “get” capability.
servers/Azure.Mcp.Server/tests/Vally/eventhubs/eventhub-get.eval.yaml Defines stimuli and outcome-based LLM judge grading for Event Hub “get” scenarios.
servers/Azure.Mcp.Server/tests/Vally/eventhubs/namespace-get.experiment.yaml Defines baseline vs treatment variants for the namespace “get/list” capability.
servers/Azure.Mcp.Server/tests/Vally/eventhubs/namespace-get.eval.yaml Defines stimuli and outcome-based LLM judge grading for namespace “get/list” scenarios.
servers/Azure.Mcp.Server/tests/Vally/.gitignore Ignores local Vally result artifacts directories.
servers/Azure.Mcp.Server/CHANGELOG.md Adds an “Other Changes” entry documenting the new Vally harness and initial experiments.
.vscode/cspell.json Adds new dictionary words related to Vally and Event Hubs eval content.

Comment on lines +55 to +59
if ($LASTEXITCODE -ne 0) {
# Check for errors (user not logged in, invalid subscription, etc.)
Write-Warn "Failed to check if resource group '$ResourceGroup' exists. Verify 'az login' and subscription."
exit 1
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 2c00671: replaced exit 1 with throw so failures propagate as exceptions and the runner can execute cleanup in finally.

Comment on lines +104 to +120
.PARAMETER PreEvalScript
Optional path to a provisioning script run BEFORE the experiments of an area (e.g.
./eventhubs/New-EventHubsResources.ps1). Use it to create the Azure resources the
eval prompts reference. -ResourceGroup and -Subscription are forwarded to it.

If not specified (and -SkipProvisioning is not set), the runner auto-discovers a
convention-named `New-*Resources.ps1` script in each area directory and uses that.

.PARAMETER PostEvalScript
Optional path to a teardown script run AFTER an area's experiments (e.g.
./eventhubs/Remove-EventHubsResources.ps1). It runs in a finally block, so it
executes even if the run or the pre-eval provisioning fails. -ResourceGroup and
-Subscription are forwarded to it.

If not specified (and -SkipProvisioning is not set), the runner auto-discovers a
convention-named `Remove-*Resources.ps1` script in each area directory and uses
that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 2c00671: removed the duplicated .PARAMETER PreEvalScript and .PARAMETER PostEvalScript blocks from comment-based help.

Comment thread servers/Azure.Mcp.Server/tests/Vally/Invoke-VallyEval.ps1 Outdated
Comment on lines +20 to +24
|-- eventhubs/ # An AREA (one subfolder per namespace)
| |-- eventhub-get.experiment.yaml # <tool>.experiment.yaml - defines baseline+treatment variants (required)
| |-- eventhub-get.eval.yaml # <tool>.eval.yaml - the shared eval spec both variants run (required)
| |-- New-EventHubsResources.ps1 # New-*Resources.ps1 - per-area provisioning (optional)
| |-- Remove-EventHubsResources.ps1 # Remove-*Resources.ps1 - per-area teardown (optional)
Comment on lines +33 to +36
The first area, `eventhubs/`, evaluates the **get Event Hub** tool
(`eventhubs_eventhub_get`). Its `eventhub-get.experiment.yaml` runs the shared
`eventhub-get.eval.yaml` as two variants that differ only in whether the Azure MCP
server is present:
LarryOsterman and others added 2 commits July 27, 2026 10:22
# Conflicts:
#	servers/Azure.Mcp.Server/tests/Vally/Invoke-VallyEval.ps1
#	servers/Azure.Mcp.Server/tests/Vally/README.md
#	servers/Azure.Mcp.Server/tests/Vally/eventhubs/eventhub-get.eval.yaml
#	servers/Azure.Mcp.Server/tests/Vally/eventhubs/eventhub-get.experiment.yaml
#	servers/Azure.Mcp.Server/tests/Vally/eventhubs/namespace-get.eval.yaml
#	servers/Azure.Mcp.Server/tests/Vally/eventhubs/namespace-get.experiment.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants