Standardize executable empty blocks on pass - #235
Merged
Conversation
Use pass for executable no-op bodies while retaining ellipses for overload and Protocol declarations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52a9a819-4e52-467d-9a9f-d862280a94c0
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes how executable-but-empty blocks are represented across the repo by replacing ellipsis-only (...) statement bodies with explicit pass, while preserving ... for typing-only constructs (e.g., @overload, Protocol).
Changes:
- Replaced ellipsis-only executable function bodies in tests with
passto match the repo’s established pattern for empty executable blocks. - Updated abstract method bodies in core SDK and providers to use
passconsistently. - Kept typing-focused usage of
...out of executable contexts (per the PR intent).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/durabletask/test_type_discovery.py | Replaces placeholder ellipsis bodies in nested test functions/classes with pass (signature/type-discovery tests). |
| tests/durabletask/test_orchestration_executor.py | Updates annotated test activity placeholders from ... to pass. |
| durabletask/serialization.py | Uses pass for DataConverter abstract method bodies to align with existing ABC usage patterns in the SDK. |
| durabletask/payload/store.py | Uses pass for PayloadStore abstract method bodies for consistency and clearer “empty executable block” intent. |
| azure-functions-durable/azure/durable_functions/internal/compat/token_source.py | Updates TokenSource.to_json() abstract method body to pass to match standardized style. |
berndverst
approved these changes
Jul 29, 2026
berndverst
left a comment
Member
There was a problem hiding this comment.
Reviewed the complete diff at f3818a5. The ellipsis-to-pass substitutions preserve signatures, abstractness, coroutine behavior, and runtime semantics, and the remaining executable ellipses are limited to overload or Protocol declarations. No actionable issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
passstatements...for typing-only@overloadandProtocoldeclarationsTesting