fix: prevent terminal hangs when PowerShell prompt fails - #376
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a Windows-specific Agent mode hang by hardening the PowerShell shell-integration prompt handling so the tool completion markers are still emitted even when the user’s prompt fails (notably in ConstrainedLanguage mode).
Changes:
- Invoke the original PowerShell prompt via the call operator (
&) instead ofScriptBlock.Invoke()to avoid ConstrainedLanguage blocking. - Guard prompt execution with
try/catchand suppress prompt errors to prevent breaking the integration flow. - Provide a fallback prompt (current directory) when the original prompt throws, returns
$null, or returns an empty string.
jdneo
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Agent mode hanging indefinitely after a terminal command completes on Windows.
Root cause
The PowerShell integration invoked the original prompt using
ScriptBlock.Invoke(). This method call is blocked inConstrainedLanguagemode. A user-defined prompt could also throw an exception or return no output.When the prompt failed, the shell integration did not emit its prompt-end marker. Consequently, the terminal command future never completed and Agent mode remained stuck on
Running run_in_terminal tool.Changes
.Invoke().Validation
ConstrainedLanguagemode.ConstrainedLanguagemode.$null..\mvnw checkstyle:checkpassed..\mvnw testpassed.Fixes #375