[master] Variant Code mandatory should not allow to refresh the production order with no variant code - #9803
Draft
neeleshsinghal wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses AB#633092 by enforcing a mandatory Production Order header Variant Code when refreshing production orders only in scenarios where lines are recalculated (Calc. Lines = Yes), while preserving support for existing variant-specific lines when Calc. Lines = No (fashion/apparel-style pattern).
Changes:
- Add a variant-mandatory validation to report 99001025 Refresh Production Order when
CalcLines = trueand the source item requires a variant. - Add a new
OnBeforeCheckVariantCodeMandatoryintegration event to allow extensions to override/handle the validation. - Add regression tests (W1/IT/BE) covering both behaviors: skip header check when
CalcLines = No, require header check whenCalcLines = Yes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Layers/W1/BaseApp/Manufacturing/Document/RefreshProductionOrder.Report.al | Adds CheckVariantCodeMandatory (gated by CalcLines) and an integration event to enforce header Variant Code when required. |
| src/Layers/W1/Tests/SCM-Manufacturing/SCMManufacturing70.Codeunit.al | Adds regression tests validating refresh behavior with/without recalculating lines under variant-mandatory conditions. |
| src/Layers/IT/Tests/SCM-Manufacturing/SCMManufacturing70.Codeunit.al | Mirrors the W1 regression tests for the IT layer. |
| src/Layers/BE/Tests/SCM-Manufacturing/SCMManufacturing70.Codeunit.al | Mirrors the W1 regression tests for the BE layer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workitem : Bug 633092: [All-E]Variant Code mandatory should not allow to refresh the production order with no variant code
Fixes AB#633092
Issue: Variant Code mandatory should not allow to refresh the production order with no variant code.
Cause: Missing CheckVariantCodeMandatory .
Solution: Added check for item variant mandatory (plus an OnBeforeCheckVariantCodeMandatory publisher).