The watcher daemon crashes with a stack trace instead of handling the connection/context resolution failure gracefully. - #496
Open
aniket866 wants to merge 1 commit into
Conversation
Signed-off-by: aniket866 <iamaniketkumarmaner@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #475
Describe the bug
Diagram
sequenceDiagram participant Watcher participant Executor participant Client as connectors.NewClient Watcher->>Executor: TriggerImport(entry) Executor->>Client: NewClient(*globalClientOpts) Note over Client: Fails (e.g. invalid context) Client-->>Executor: nil, err Note over Executor: Logs error, but DOES NOT return! Executor->>Executor: mc.UploadArtifact(entry.FilePath, entry.MainArtifact) Note over Executor: Panic: nil pointer dereference (mc is nil)Description
In
pkg/watcher/executor.go, theTriggerImportfunction instantiates the Microcks client usingconnectors.NewClient. If this fails (e.g., due to an invalid context or server address), it prints an error message but continues execution instead of returning early. It subsequently callsmc.UploadArtifact(), causing a nil pointer dereference panic.Impact
The watcher daemon crashes with a stack trace instead of handling the connection/context resolution failure gracefully.
Steps to Reproduce
TriggerImport, which prints[ERROR] Cannot connect to Microcks client...and immediately panics with a segmentation fault.