Added default ellipsis truncation to ListItemText - #1758
Conversation
|
Warning Review limit reached
Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesListItemText behavior
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
6b7abc0 to
67735c2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/base/ListItemText/ListItemText.tsx`:
- Around line 16-17: Update the slot prop handling in ListItemText so
function-valued primary and secondary slot props remain callbacks receiving the
owner state, while object-valued props retain the default noWrap setting. Ensure
consumer-provided values override defaults in both cases.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: bc4baaf7-0ee7-4e97-afc9-31ca6d804c1b
📒 Files selected for processing (1)
src/base/ListItemText/ListItemText.tsx
f2e4293 to
23b60b6
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/base/ListItemText/ListItemText.tsx`:
- Around line 7-10: Update withNoWrapDefault so both ownerState callback
parameters use the imported ListItemTextOwnerState type instead of any,
including the slotProp function signature and returned callback. Add the type
import from `@mui/material/ListItemText` and preserve the existing behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4369bda2-a2f6-44cf-b3a8-938d4db613fa
📒 Files selected for processing (1)
src/base/ListItemText/ListItemText.tsx
23b60b6 to
9a4145f
Compare
Signed-off-by: Utkarsh Maurya <deepraj5484@gmail.com>
Signed-off-by: Utkarsh Maurya <deepraj5484@gmail.com>
Signed-off-by: Utkarsh Maurya <deepraj5484@gmail.com>
9a4145f to
d95f17f
Compare
NSTKrishna
left a comment
There was a problem hiding this comment.
@Utkarsh-Mauryaa You can add a tooltip that only appears when the ellipsis is active
|
@NSTKrishna |
|
@NSTKrishna I agree. We can show the full ListItemText in a tooltip when the user hovers over the list item. |
|
It needs to be merged first I guess before I can start working on the tooltip fix in the downstream. @KhushamBansal @NSTKrishna ?? |
Yes , you can cover the tooltip improvement in this issue meshery/meshery#20483 |


Notes for Reviewers
Signed commits
Summary by CodeRabbit