✨ Add MachineHealthCheck node-deleting timeout - #13880
Conversation
Signed-off-by: Miltiadis Alexis <alexmiltiadis@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @miltalex. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/hold before review, or possibly close because we have yet an agreed path forward for the problem that this PR is trying to solve (and PR review is not the best way to have those kind of discussions) see #13591 (comment) (let's discuss first in this issue how the MHC should looks like) and also #13591 (comment) (it would be nice to hear also a few other opinions on this topic) |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This adds an optional
checks.nodeDeleting.timeoutSecondscheck toMachineHealthCheck. When configured, MHC treats a Machine as unhealthy if its associated Node has had adeletionTimestampfor longer than the configured timeout. SettingtimeoutSeconds: 0triggers remediation as soon as the Node starts deleting; leavingchecks.nodeDeletingunset preserves the existing behavior.This enables workload-cluster operators to trigger normal Cluster API remediation by deleting a Node, while still respecting the regular remediation flow, drain settings, and Machine deletion behavior.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #13591