Skip to content

✨ Add MachineHealthCheck node-deleting timeout - #13880

Open
miltalex wants to merge 1 commit into
kubernetes-sigs:mainfrom
miltalex:feat/mch-node-deleting
Open

✨ Add MachineHealthCheck node-deleting timeout#13880
miltalex wants to merge 1 commit into
kubernetes-sigs:mainfrom
miltalex:feat/mch-node-deleting

Conversation

@miltalex

@miltalex miltalex commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This adds an optional checks.nodeDeleting.timeoutSeconds check to MachineHealthCheck. When configured, MHC treats a Machine as unhealthy if its associated Node has had a deletionTimestamp for longer than the configured timeout. Setting timeoutSeconds: 0 triggers remediation as soon as the Node starts deleting; leaving checks.nodeDeleting unset preserves the existing behavior.
This enables workload-cluster operators to trigger normal Cluster API remediation by deleting a Node, while still respecting the regular remediation flow, drain settings, and Machine deletion behavior.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #13591

Signed-off-by: Miltiadis Alexis <alexmiltiadis@gmail.com>
@kubernetes-prow kubernetes-prow Bot added the do-not-merge/needs-area PR is missing an area label label Jul 6, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow

Copy link
Copy Markdown
Contributor

This PR is currently missing an area label, which is used to identify the modified component when generating release notes.

Area labels can be added by org members by writing /area ${COMPONENT} in a comment

Please see the labels list for possible areas.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 6, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from JoelSpeed July 6, 2026 14:48
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @miltalex. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow
kubernetes-prow Bot requested a review from richardcase July 6, 2026 14:48
@miltalex

miltalex commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2026
@fabriziopandini

fabriziopandini commented Jul 13, 2026

Copy link
Copy Markdown
Member

/hold before review, or possibly close because we have yet an agreed path forward for the problem that this PR is trying to solve (and PR review is not the best way to have those kind of discussions)

see #13591 (comment) (let's discuss first in this issue how the MHC should looks like) and also #13591 (comment) (it would be nice to hear also a few other opinions on this topic)

@kubernetes-prow kubernetes-prow Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 13, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/needs-area PR is missing an area label needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trigger graceful Machine disruption via Node deletion

2 participants