Skip to content

Align synchronous resource deletion responses - #2664

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-client:masterfrom
tamird:tamird/sync-job-delete-status-compat
Jul 31, 2026
Merged

Align synchronous resource deletion responses#2664
kubernetes-prow[bot] merged 1 commit into
kubernetes-client:masterfrom
tamird:tamird/sync-job-delete-status-compat

Conversation

@tamird

@tamird tamird commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

/kind bug

Individual resource deletion may return either the deleted resource or a Status. Generate synchronous responses from the same corrected object schema already used by asyncio, preserving the full response without fabricating V1Status or stringifying structured resource status. Exercise both response shapes over real HTTP, update the Job example, and preserve background garbage collection in end-to-end coverage.

Compatibility: Relative to released v36, 58 synchronous individual-deletion methods and their HTTP-info variants now return dictionaries instead of V1Status. Update attribute access such as result.status to result.get("status"). Collection-delete methods and operations with an already resource-typed response are unchanged.

Generator: kubernetes-client/gen#309
Maintainer discussion: kubernetes-client/gen#306 (comment)

action required: Synchronous individual resource deletion methods that previously returned V1Status now return dictionaries containing the actual deleted resource or Status. Replace result.status with result.get("status").

@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jul 30, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from roycaihw July 30, 2026 21:53
@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 30, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from yliaog July 30, 2026 21:53
@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 30, 2026
@tamird
tamird force-pushed the tamird/sync-job-delete-status-compat branch from a6334a4 to 213a5f4 Compare July 30, 2026 23:37
@kubernetes-prow kubernetes-prow Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2026
@tamird tamird changed the title Restore synchronous Job deletion compatibility Align synchronous resource deletion responses Jul 30, 2026
@kubernetes-prow kubernetes-prow Bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 30, 2026
@yliaog

yliaog commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

thanks for the PR

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tamird, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit cba2395 into kubernetes-client:master Jul 31, 2026
10 checks passed
@tamird
tamird deleted the tamird/sync-job-delete-status-compat branch July 31, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants