Skip to content

Fix NetworkCurl race on pipe close - #1719

Merged
andrey-kashcheev merged 1 commit into
heremaps:masterfrom
exposight:patch-1
Jul 29, 2026
Merged

Fix NetworkCurl race on pipe close#1719
andrey-kashcheev merged 1 commit into
heremaps:masterfrom
exposight:patch-1

Conversation

@exposight

Copy link
Copy Markdown
Contributor

ThreadSanitizer detected a data race on the pipe member between deinitializing thread making notification and the worker thread doing teardown. The solution is to perform both under the same lock to avoid race.

Relates-To: HERESDK-4984, OCMAM-772

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.40%. Comparing base (3496dd4) to head (5f74c47).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1719      +/-   ##
==========================================
+ Coverage   80.39%   80.40%   +0.01%     
==========================================
  Files         356      356              
  Lines       14294    14295       +1     
  Branches     1566     1565       -1     
==========================================
+ Hits        11491    11493       +2     
+ Misses       2174     2173       -1     
  Partials      629      629              

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ThreadSanitizer detected a data race on the pipe member between
deinitializing thread making notification and the worker thread
doing teardown.

Relates-To: HERESDK-4984, OCMAM-772

Signed-off-by: Vasyl Bilous <ext-vasyl.bilous@here.com>
@andrey-kashcheev
andrey-kashcheev merged commit 6363d4f into heremaps:master Jul 29, 2026
28 checks passed
@exposight
exposight deleted the patch-1 branch July 29, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants