fix: validate audio sample rates - #6506
Closed
fallintoplace wants to merge 1 commit into
Closed
Conversation
copybara-service Bot
pushed a commit
that referenced
this pull request
Jul 30, 2026
Merge #6506 - match `rate` only as a complete, case-insensitive MIME parameter - reject non-positive source and destination sample rates before returning or resampling - cover zero-rate inputs, `bitrate` parameters, and uppercase `RATE` parameters PiperOrigin-RevId: 956811306
Collaborator
|
Thank you @fallintoplace for your contribution! 🎉 Your changes have been successfully imported and merged via Copybara in commit d24c84c. Closing this PR as the changes are now in the main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rateonly as a complete, case-insensitive MIME parameterbitrateparameters, and uppercaseRATEparametersWhy
parse_sample_ratepreviously treatedrate=as an arbitrary substring, so parameters such asbitrate=128000could be interpreted as sample rates. It also accepted zero, which could reach a division by zero inresample_pcm16. Direct calls with a zero destination rate had the same problem.Rejecting invalid rates explicitly avoids silently producing incorrectly pitched or timed audio.
Validation
uv run pytest tests/unittests/evaluation/test_audio_utils.py -quv run pre-commit run --files src/google/adk/evaluation/_audio_utils.py tests/unittests/evaluation/test_audio_utils.py