[rig-header] Update rig.ts agentic file-summary header (d697b7b → 35bd710) - #289
Merged
Merged
Conversation
Add missing exported types to header: AgentOptions, AgentAskOptions, CallOptions, ToolHandler, ToolParameters. Fix LauncherIo (stdin,stdout only, no stderr). Fix LaunchOptions fields (cwd,startServer,typecheck). Update @last-analyzed SHA and edit-time. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
approved these changes
Jul 30, 2026
pelikhan
marked this pull request as ready for review
July 30, 2026 06:26
Contributor
Author
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Skills-Based Review
Applied /codebase-design — header accurately reflects the current API surface. All corrections verified against source.
Verified changes:
- AgentOptions, AgentAskOptions, CallOptions, ToolHandler, ToolParameters all match actual exports
- LaunchOptions fields corrected to {cwd?,startServer?,typecheck?}
- LauncherIo stderr removal is correct; type only has stdin and stdout
- Agent.ask return type corrected to Promise(string)
@depsupdated with node:os,fs — both imported
No blocking issues found.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 24.1 AIC · ⌖ 2.62 AIC · ⊞ 6.4K
Comment /matt to run again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the agentic file-summary header in
skills/rig/rig.tsto reflect the current API surface as of commit35bd710.Changes
New exports documented (
[NEW]):T:AgentOptions—{model, systemMessage?, tools?}passed toAgentFactoryT:AgentAskOptions—{signal?, outputSchema?}per-ask overrides onAgent.askT:CallOptions—{signal?, timeout?, model?, maxTurns?}per-call overrides forAgentFnT:ToolHandler<TArgs>—(args: TArgs) => unknown | Promise<unknown>handler signatureT:ToolParameters—Schema | Record<string, unknown>for tool parameter schemaFixes:
T:LauncherIo— corrected to{stdin, stdout}(nostderrfield; header was wrong)T:LaunchOptions— corrected fields to{cwd?, startServer?, typecheck?}(was stale:server,token,headers,cwd,args)T:Agent.askreturn type corrected toPromise<string>(wasPromise<unknown>)@depsupdated to includenode:os,fswhich are imported in the fileMetrics
old_lines: 88,new_lines: 93changed_lines: ~12,change_ratio: ~0.13has_new_api: true (5 new exported types)